i18n(ja): restore 2-word TiDB Cloud UI labels to English - #23535
Open
yahonda wants to merge 6 commits into
Open
Conversation
Continues the UI-labels-English sweep (see PR pingcap#23519 for the 4-word and 3-word batch) with 2-word labels: 382 target labels / 1391 occurrences across 137 tidb-cloud/ files (excluding releases/). Unlike the previous batch, every candidate label was verified against the actual TiDB Cloud console source (tidbcloud/dbaas-ui) or, for third-party consoles, general knowledge of their UI conventions, BEFORE applying the mechanical fix — not after. This kept the false- revert rate much lower than the convert-then-audit approach used for the 3/4-word batch, though it doesn't eliminate the position-pairing risk entirely: 5 occurrences turned out to be mismapped due to EN/JA word-order differences shifting bold-span indices (e.g. 'Select PagerDuty from the Subscriber Type drop-down list' reorders in Japanese, so positional pairing swapped which JA span got which EN label) and were corrected by hand after cross-checking against EN. Also fixed ~25 'straddling bracket' MT defects surfaced by the fix (leftover decoration characters split across the wrong side of ** markers from the original translation) and ~80 dropped-particle instances (を/が) where the original bold span had swallowed a trailing particle that the English replacement doesn't need. 228 labels were checked but not confirmed as literal UI text (via dbaas-ui or general knowledge) and were left in Japanese, matching the conservative policy from the previous batch.
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
missing-translation-status
…ntext verification A user spot-check found 'same region' confirmed only via a source-code COMMENT in dbaas-ui (never rendered on screen), exposing a gap in the verification method: grep-based confirmation doesn't distinguish a genuine rendered UI string from incidental text inside code comments or ordinary prose sentences that happen to contain the phrase. Re-verified all 382 confirmed labels with a stricter classifier (label:/title:/name:/placeholder:/data-mp-event/tight-JSX-text patterns vs. comment-only vs. prose-embedded matches). Found and reverted: - 3 more comment-only false positives (Auto Login, Backup List, experimental feature) plus the already-known 'Custom format' and 'Do nothing' cases (Custom format reverted for consistency since its own confirmation was equally bogus, despite moderate independent confidence in the underlying Airbyte claim; Do nothing kept, since it's independently a well-known, stable AWS DMS console option) - 6 prose-embedded false positives in marketing/conceptual sections (Advanced security, Enhanced capabilities, High availability x2, Columnar storage, Instant elasticity, Best practice x2, Billing notifications) that happened to also appear as ordinary words within an unrelated sentence or comment elsewhere in dbaas-ui - 2 plain emphasis/RFC-style bold spans mistaken for labels (MUST NOT, does not, public internet) that EN just happens to bold for emphasis, not as UI references Also fixed a severe word-order-driven mismapping in migrate-from-mysql-using-data-migration.md: EN bolds physical/logical mode before existing/incremental data in one sentence, but JA's natural word order reverses the two clauses, so positional pairing cross-wired all four spans (existing data data got physical mode's slot and vice versa) across 3 occurrences. Fixed by hand, keeping physical mode/logical mode in English (independently confirmed real TiDB DM feature-mode names in dbaas-ui) while reverting existing data/incremental data to Japanese (generic descriptive nouns, not discrete UI labels — their own dbaas-ui 'confirmations' were also prose-fragment false positives).
…ings found via 1:1 EN comparison
A user spot-check of 'Generate Password' surfaced a distinct defect
class from the earlier revert pass: several JA bold spans were
already oversized BEFORE this batch (a pre-existing MT defect
wrapping an entire clause, not just the label, in ** markers). When
the mechanical fix matched one of these to a confirmed 2-word EN
label, it replaced the ENTIRE oversized span — including content that
was never part of the label — with just the short English label,
silently destroying the rest of the sentence.
Fixed in 11 files by reconstructing each sentence against its EN
source: import-with-mysql-cli-premium.md and
connect-via-standard-connection-serverless.md ('Generate Password'),
tidb-cloud-tls-connect-to-premium.md ('Auto-generate Password'),
import-csv-files.md and import-parquet-files.md ('Destination
Mapping' colliding with an HTML-anchor-embedded checkbox label),
essential-changefeed-sink-to-kafka.md and
changefeed-sink-to-apache-kafka.md ('Distribution Mode' swapped with
its own dropdown value), set-up-private-endpoint-connections-on-azure.md
('connection method' swapped with its dropdown value), and
configure-external-storage-access.md ('Target Connection' swapped
with the Amazon S3 / Azure Blob Storage value in both branches of the
CustomContent block).
Also fixed one same-shape regression unrelated to any oversized span:
backup-and-restore.md's 'gsutil URI' (already English pre-batch) lost
its trailing を particle because the particle itself is kana, so the
whole mixed English+particle span satisfied the kana/kanji-detection
filter and got swept into the candidate pool by accident.
Additionally converted backup-and-restore-serverless.md's plain
Markdown table (Backup setting/Backup Cycle/Backup Retention/Backup
Time row headers) to match EN exactly — confirmed genuine via
dbaas-ui, this content was outside the bold-span sweep's mechanical
scope since it's plain table text, not **bold**, so needed a manual
follow-up fix.
…GCP Create role button
changefeed-sink-to-cloud-storage.md had a pre-existing MT defect
(predating this batch): the sentence was missing 'ページ' and put
'に移動して' before the Roles link instead of after, reading as
'Navigate to, [Roles] Create role click' instead of 'Navigate to the
Roles page, then click Create role'. Reconstructed against EN ('Go
to the [Roles] page, and then click **Create role**.').
dedicated-external-storage.md had a straddling-bracket leftover
('「役割') from the original 「役割の作成」 span, where only the
closing quote had been captured inside the bold — same defect class
as several others fixed in this batch's earlier commits.
…zed-bold-span defect Same pattern as the earlier import-with-mysql-cli-premium.md and tidb-cloud-tls-connect-to-premium.md fixes: the pre-existing JA bold span wrapped the whole clause instead of just the button label, so the mechanical fix replaced it entirely, losing 'click X to generate a random password' down to just the label. Confirmed via corpus-wide grep that these were the last 2 remaining instances of this exact pattern.
high-availability-with-multi-az.md uses these as architectural category headers introducing an HA-behavior explanation paragraph for each component, not as references to a clickable console element. Same 'category header, not a UI reference' precedent already applied to architecture-concepts.md's High availability / Columnar storage headings, despite dbaas-ui also showing genuine node-related UI strings elsewhere in the product. 'ノード' is also the established, consistent corpus-wide translation for 'node' throughout TiDB docs.
yahonda
marked this pull request as ready for review
August 17, 2026 02:37
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
This was referenced Aug 17, 2026
qiancai
added
translation/no-need
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Continues the UI-labels-English sweep (see #23519 for the 4-word and 3-word batch) with 2-word labels: 382 target labels / 1391 occurrences across 137
tidb-cloud/files (excludingreleases/).Unlike the previous batch, every candidate label was verified against the actual TiDB Cloud console source (
tidbcloud/dbaas-ui) or, for third-party consoles, general knowledge of their UI conventions, before applying the mechanical fix — not after. This kept the false-revert rate much lower than the convert-then-audit approach used for the 3/4-word batch, though it doesn't eliminate the position-pairing risk entirely: 5 occurrences turned out to be mismapped due to EN/JA word-order differences shifting bold-span indices (e.g. "Select PagerDuty from the Subscriber Type drop-down list" reorders in Japanese, so positional pairing swapped which JA span got which EN label) and were corrected by hand after cross-checking against EN.Also fixed ~25 "straddling bracket" MT defects surfaced by the fix (leftover decoration characters split across the wrong side of
**markers from the original translation) and ~80 dropped-particle instances (を/が) where the original bold span had swallowed a trailing particle that the English replacement doesn't need.228 labels were checked but not confirmed as literal UI text (via dbaas-ui or general knowledge) and were left in Japanese, matching the conservative policy from the previous batch.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?