fix(ja): fix Japanese translations in release notes#23181
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates several release notes files by replacing Japanese katakana translations of contributor names and other terms with their English GitHub handles or terms. However, the automated script used was too broad, resulting in the unintended replacement of descriptive link text for pull requests, issues, and documentation with raw paths. Additionally, there are inconsistencies in the translation of "first-time contributor" (e.g., leaving some instances as 初回投稿者 while translating others to (first-time contributor)). Feedback has been provided to revert these unintended link text changes and ensure consistent translation of contributor-related terminology across all files.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
I am having trouble creating individual review comments. Click here to see my feedback.
releases/release-1.0.3.md (12-19)
Unintended Replacement of Descriptive PR Links
It appears that the automated script or regular expression used to replace katakana contributor handles with GitHub usernames was too broad. It matched descriptive Japanese text inside markdown links pointing to GitHub (such as pull requests, issues, blobs, and projects) and replaced them with raw paths/URLs.
This removes valuable descriptive information from the release notes (e.g., changing [トランザクション競合シナリオでのパフォーマンスの最適化](...) to [pingcap/tidb/pull/5051](...)).
Please revert these changes and refine your replacement script to only target contributor names (e.g., matching only github.com/<username> where <username> is a single path segment, and excluding paths containing /pull/, /issues/, /blob/, /tree/, /projects/, /commit/, etc.).
- [トランザクション競合シナリオでのパフォーマンスの最適化](https://github.com/pingcap/tidb/pull/5051)
- [設定ファイルに`TokenLimit`オプションを追加する](https://github.com/pingcap/tidb/pull/5107)
- [スロークエリログにデフォルトのデータベースを出力する](https://github.com/pingcap/tidb/pull/5107)
- [クエリ実行時間メトリックから DDL ステートメントを削除します](https://github.com/pingcap/tidb/pull/5107)
- [クエリコストの見積もりを最適化する](https://github.com/pingcap/tidb/pull/5140)
- [テーブル作成時のインデックスプレフィックスの問題を修正](https://github.com/pingcap/tidb/pull/5149)
- [Float 型の式を TiKV にプッシュダウンする機能をサポート](https://github.com/pingcap/tidb/pull/5153)
- [離散整数プライマリインデックスを持つテーブルにインデックスを追加するのが遅い問題を修正しました](https://github.com/pingcap/tidb/pull/5155)
releases/release-2.1-ga.md (122)
Unintended Replacement of Descriptive Doc Link
Similar to other files, the descriptive text of this documentation link was replaced with the raw path due to an over-broad regex/script. Please revert this change.
- [`ddl/owner/resign` HTTP インターフェースを使用して DDL 所有者を解放し、新しい DDL 所有者の選出を開始できるようにサポートします](https://github.com/pingcap/tidb/blob/release-2.1/docs/tidb_http_api.md)
releases/release-2.1-ga.md (168-178)
Unintended Replacement of Technical Terms and Interface Names
The automated script replaced descriptive technical terms (like [PDシミュレータ]) and interface names (like [GetPrevRegionインターフェース]) with raw repository paths. Please revert these changes.
- スケジューリングシナリオをシミュレートするために[PDシミュレータ](https://github.com/pingcap/pd/tree/release-2.1/tools/pd-simulator)改善
- APIと操作ツール
- `TiDB reverse scan`機能をサポートするには[`GetPrevRegion`インターフェース](https://github.com/pingcap/kvproto/blob/8e3f33ac49297d7c93b61a955531191084a2f685/proto/pdpb.proto#L40)追加します
- [`BatchSplitRegion`インターフェース](https://github.com/pingcap/kvproto/blob/8e3f33ac49297d7c93b61a955531191084a2f685/proto/pdpb.proto#L54)追加すると TiKVリージョン分割が高速化されます
- TiDBで分散GCをサポートするには[`GCSafePoint`インターフェース](https://github.com/pingcap/kvproto/blob/8e3f33ac49297d7c93b61a955531191084a2f685/proto/pdpb.proto#L64-L66)追加します
- TiDBで分散GCをサポートするには、 [`GetAllStores`インターフェース](https://github.com/pingcap/kvproto/blob/8e3f33ac49297d7c93b61a955531191084a2f685/proto/pdpb.proto#L32)追加します。
releases/release-7.1.0.md (487)
Inconsistent Translation of "first-time contributor"
It looks like the script replaced 初投稿者 with (first-time contributor) but missed 初回投稿者 (which also means first-time contributor). For consistency across all release notes, please replace (初回投稿者) with (first-time contributor) here as well.
- [yujiarista](https://github.com/yujiarista) (first-time contributor)
References
- Use consistent terminology across all documentation files. (link)
releases/release-8.1.0.md (295)
Inconsistent Translation of "first-time contributor"
Please replace (初回投稿者) with (first-time contributor) here as well for consistency.
- [arturmelanchyk](https://github.com/arturmelanchyk) (first-time contributor)
References
- Use consistent terminology across all documentation files. (link)
3c608f0 to
b17e589
Compare
4e5e815 to
1fd2c1e
Compare
4ebe8a0 to
07dc07b
Compare
07dc07b to
81ac6d2
Compare
What is changed, added or deleted? (Required)
Various Japanese translation fixes in release notes and related files (91 files):
アスタ・シー→Asta Xie,モバイク→Mobike,サムスン電子→Samsung Electronics,アンシブル→Ansible)寄稿者→貢献者,行動の変化→動作の変更,特徴→機能,Security→セキュリティ初投稿者/初回投稿者→初回貢献者(with format matching English original)TiDBBinlog→TiDB BinlogDecision criteria
Which TiDB version(s) do your changes apply to? (Required)
Do your changes match any of the following descriptions?