Skip to content

fix(ja): fix Japanese translations in release notes#23181

Open
yahonda wants to merge 5 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-contributor-handles
Open

fix(ja): fix Japanese translations in release notes#23181
yahonda wants to merge 5 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-contributor-handles

Conversation

@yahonda

@yahonda yahonda commented Jul 1, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Various Japanese translation fixes in release notes and related files (91 files):

  1. GitHub usernames: Revert translated contributor handles to original identifiers (katakana/hiragana/kanji renderings → actual GitHub usernames)
  2. Company/person names: Revert translated names to English originals (e.g., アスタ・シーAsta Xie, モバイクMobike, サムスン電子Samsung Electronics, アンシブルAnsible)
  3. Section heading fixes: 寄稿者貢献者, 行動の変化動作の変更, 特徴機能, Securityセキュリティ
  4. Contributor label: 初投稿者/初回投稿者初回貢献者 (with format matching English original)
  5. Product name: TiDBBinlogTiDB Binlog
  6. Missing newlines: Fixed missing newlines between contributor entries

Decision criteria

  • GitHub usernames are identifiers, not natural language text. They should never be translated and must be kept as-is.
  • Company names and personal names in acknowledgment sections should use the original English form.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch (91 files changed)

@ti-chi-bot

ti-chi-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several release notes files by replacing Japanese katakana translations of contributor names and other terms with their English GitHub handles or terms. However, the automated script used was too broad, resulting in the unintended replacement of descriptive link text for pull requests, issues, and documentation with raw paths. Additionally, there are inconsistencies in the translation of "first-time contributor" (e.g., leaving some instances as 初回投稿者 while translating others to (first-time contributor)). Feedback has been provided to revert these unintended link text changes and ensure consistent translation of contributor-related terminology across all files.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

releases/release-1.0.3.md (12-19)

high

Unintended Replacement of Descriptive PR Links

It appears that the automated script or regular expression used to replace katakana contributor handles with GitHub usernames was too broad. It matched descriptive Japanese text inside markdown links pointing to GitHub (such as pull requests, issues, blobs, and projects) and replaced them with raw paths/URLs.

This removes valuable descriptive information from the release notes (e.g., changing [トランザクション競合シナリオでのパフォーマンスの最適化](...) to [pingcap/tidb/pull/5051](...)).

Please revert these changes and refine your replacement script to only target contributor names (e.g., matching only github.com/<username> where <username> is a single path segment, and excluding paths containing /pull/, /issues/, /blob/, /tree/, /projects/, /commit/, etc.).

-   [トランザクション競合シナリオでのパフォーマンスの最適化](https://github.com/pingcap/tidb/pull/5051)
-   [設定ファイルに`TokenLimit`オプションを追加する](https://github.com/pingcap/tidb/pull/5107)
-   [スロークエリログにデフォルトのデータベースを出力する](https://github.com/pingcap/tidb/pull/5107)
-   [クエリ実行時間メトリックから DDL ステートメントを削除します](https://github.com/pingcap/tidb/pull/5107)
-   [クエリコストの見積もりを最適化する](https://github.com/pingcap/tidb/pull/5140)
-   [テーブル作成時のインデックスプレフィックスの問題を修正](https://github.com/pingcap/tidb/pull/5149)
-   [Float 型の式を TiKV にプッシュダウンする機能をサポート](https://github.com/pingcap/tidb/pull/5153)
-   [離散整数プライマリインデックスを持つテーブルにインデックスを追加するのが遅い問題を修正しました](https://github.com/pingcap/tidb/pull/5155)

releases/release-2.1-ga.md (122)

high

Unintended Replacement of Descriptive Doc Link

Similar to other files, the descriptive text of this documentation link was replaced with the raw path due to an over-broad regex/script. Please revert this change.

    -   [`ddl/owner/resign` HTTP インターフェースを使用して DDL 所有者を解放し、新しい DDL 所有者の選出を開始できるようにサポートします](https://github.com/pingcap/tidb/blob/release-2.1/docs/tidb_http_api.md)

releases/release-2.1-ga.md (168-178)

high

Unintended Replacement of Technical Terms and Interface Names

The automated script replaced descriptive technical terms (like [PDシミュレータ]) and interface names (like [GetPrevRegionインターフェース]) with raw repository paths. Please revert these changes.

    -   スケジューリングシナリオをシミュレートするために[PDシミュレータ](https://github.com/pingcap/pd/tree/release-2.1/tools/pd-simulator)改善

-   APIと操作ツール

    -   `TiDB reverse scan`機能をサポートするには[`GetPrevRegion`インターフェース](https://github.com/pingcap/kvproto/blob/8e3f33ac49297d7c93b61a955531191084a2f685/proto/pdpb.proto#L40)追加します

    -   [`BatchSplitRegion`インターフェース](https://github.com/pingcap/kvproto/blob/8e3f33ac49297d7c93b61a955531191084a2f685/proto/pdpb.proto#L54)追加すると TiKVリージョン分割が高速化されます

    -   TiDBで分散GCをサポートするには[`GCSafePoint`インターフェース](https://github.com/pingcap/kvproto/blob/8e3f33ac49297d7c93b61a955531191084a2f685/proto/pdpb.proto#L64-L66)追加します

    -   TiDBで分散GCをサポートするには、 [`GetAllStores`インターフェース](https://github.com/pingcap/kvproto/blob/8e3f33ac49297d7c93b61a955531191084a2f685/proto/pdpb.proto#L32)追加します。

releases/release-7.1.0.md (487)

low

Inconsistent Translation of "first-time contributor"

It looks like the script replaced 初投稿者 with (first-time contributor) but missed 初回投稿者 (which also means first-time contributor). For consistency across all release notes, please replace (初回投稿者) with (first-time contributor) here as well.

-   [yujiarista](https://github.com/yujiarista) (first-time contributor)
References
  1. Use consistent terminology across all documentation files. (link)

releases/release-8.1.0.md (295)

low

Inconsistent Translation of "first-time contributor"

Please replace (初回投稿者) with (first-time contributor) here as well for consistency.

-   [arturmelanchyk](https://github.com/arturmelanchyk) (first-time contributor)
References
  1. Use consistent terminology across all documentation files. (link)

@yahonda yahonda force-pushed the fix-ja-contributor-handles branch from 3c608f0 to b17e589 Compare July 1, 2026 03:13
@yahonda yahonda changed the title fix(ja): replace katakana contributor handles with GitHub usernames fix(ja): replace Japanese contributor handles with GitHub usernames Jul 1, 2026
@yahonda yahonda force-pushed the fix-ja-contributor-handles branch 3 times, most recently from 4e5e815 to 1fd2c1e Compare July 1, 2026 03:19
@yahonda yahonda changed the title fix(ja): replace Japanese contributor handles with GitHub usernames fix(ja): replace non-English contributor handles with GitHub usernames Jul 1, 2026
@yahonda yahonda changed the title fix(ja): replace non-English contributor handles with GitHub usernames fix(ja): use GitHub usernames as-is instead of translating them Jul 1, 2026
@yahonda yahonda changed the title fix(ja): use GitHub usernames as-is instead of translating them fix(ja): keep GitHub usernames as identifiers instead of translating them Jul 1, 2026
@yahonda yahonda marked this pull request as ready for review July 1, 2026 03:24
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 1, 2026
@yahonda yahonda force-pushed the fix-ja-contributor-handles branch 2 times, most recently from 4ebe8a0 to 07dc07b Compare July 1, 2026 04:52
@yahonda yahonda force-pushed the fix-ja-contributor-handles branch from 07dc07b to 81ac6d2 Compare July 1, 2026 04:53
@yahonda yahonda changed the title fix(ja): keep GitHub usernames as identifiers instead of translating them fix(ja): fix Japanese translations in release notes Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant