feat(diffshub): persist display preferences#853
Open
NathanDrake2406 wants to merge 2 commits into
Open
Conversation
DiffsHub display controls previously reset between visits, so repeat review sessions had to reapply the same view, wrap, line-number, background, indicator, and collapse preferences. The display state lived only in ReviewUI component state. This stores a versioned, locally validated preference payload, reuses the existing browser storage boundary for theme persistence, and hydrates the viewer only after preferences are loaded. Closes pierrecomputer#851.
|
@NathanDrake2406 is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Persist DiffsHub display settings locally so repeat review sessions keep the viewer preferences a user selected last time.
This includes diff layout, wrapping, line numbers, backgrounds, indicator style, and collapsed/expanded file state. Mobile still uses unified view when needed without changing the user's saved desktop layout preference.
Validation
AGENT=1 bun test apps/diffshub/lib/test/displayPreferences.test.ts apps/diffshub/lib/test/reviewDisplayPreferences.test.tsxAGENT=1 ./node_modules/.bin/moon run diffshub:typecheckAGENT=1 ./node_modules/.bin/moon run diffshub:testAGENT=1 ./node_modules/.bin/moon run diffshub:buildCloses #851.