feat(diffshub): add code font preference#854
Draft
NathanDrake2406 wants to merge 4 commits into
Draft
Conversation
DiffsHub display controls previously reset between visits, so repeat review sessions had to reapply the same view, wrap, line-number, background, indicator, and collapse preferences. The display state lived only in ReviewUI component state. This stores a versioned, locally validated preference payload, reuses the existing browser storage boundary for theme persistence, and hydrates the viewer only after preferences are loaded. Closes pierrecomputer#851.
|
@NathanDrake2406 is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
NathanDrake2406
force-pushed
the
diffshub-code-font-preference
branch
from
cb86d60 to
3e398fc
Compare
DiffsHub now has a persisted display preference payload, so the code font can live beside the other viewer settings instead of adding another storage boundary. This adds Berkeley, Geist Mono, and system monospace choices, applies the selected family through the existing --diffs-font-family hook, and validates stored font values with the same per-field preference parser. Closes pierrecomputer#852.
NathanDrake2406
force-pushed
the
diffshub-code-font-preference
branch
from
3e398fc to
e1e2d38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a code font preference to DiffsHub display settings. This is stacked on #853 so the font choice is saved with the rest of the local display preferences.
The UI offers
DefaultandCustom. Default keeps the current bundled Berkeley Mono behavior. Custom accepts a local installed font name, supports common shorthand for editor fonts, and also accepts system-monospace terms likesystemormonospacewithout adding any new font assets or remote font loading.Dependency
Depends on #853. Until #853 lands, this PR includes the display-preference persistence commit in its comparison.
Validation
AGENT=1 bun test apps/diffshub/lib/test/displayPreferences.test.ts apps/diffshub/lib/test/reviewDisplayPreferences.test.tsxAGENT=1 ./node_modules/.bin/oxlint --type-aware --tsconfig tsconfig.oxlint.json apps/diffshub/components/DiffsHubHeader.tsx apps/diffshub/lib/displayPreferences.ts apps/diffshub/lib/test/displayPreferences.test.ts apps/diffshub/lib/test/reviewDisplayPreferences.test.tsxAGENT=1 ./node_modules/.bin/moon run diffshub:typecheckAGENT=1 ./node_modules/.bin/moon run diffshub:testAGENT=1 ./node_modules/.bin/moon run diffshub:buildCloses #852.