Skip to content

Expect attachments on the Print All Posts print page #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bonelifer merged 1 commit into from
Oct 28, 2026
Merged

Expect attachments on the Print All Posts print page #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions phpbb-test-board/feature_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,7 @@ def sees_ip(s: requests.Session) -> bool:


def check_printallposts(b: Board) -> None:
# A reply, so the topic has two posts, and an image attached to the welcome post, which the
# print page leaves out like phpBB's own print view
# A reply, so the topic has two posts, and an image attached to the welcome post
forum = b.sql("SELECT forum_id FROM phpbb_posts WHERE post_id = 1")[0][0]
now = int(time.time())
b.sql("INSERT INTO phpbb_posts (topic_id, forum_id, poster_id, poster_ip, post_time, post_visibility, "
Expand All @@ -295,8 +294,7 @@ def check_printallposts(b: Board) -> None:
body = admin.get(f"{b.base}/viewtopic.php?t=1&view=printall").text
ok("Second probe post" in body and "This is an example post" in body,
"with one post per page, the print page still shows both posts")
ok("printall-probe.gif" not in body and "attachbox" not in body,
"no attachments on the print page, as in phpBB's own print view")
ok("printall-probe.gif" in body, "the print page shows the post's attachment")
finally:
probe.unlink(missing_ok=True)

Expand Down
Loading