Skip to content

Fix GH-23764: Built-in server leaks fd on HEAD request for static file #23765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakubskopal wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+7 −0
Open

Fix GH-23764: Built-in server leaks fd on HEAD request for static file #23765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.4.27

- CLI:
. Fixed bug GH-23764 (Built-in server leaks a file descriptor on every HEAD
request for a static file). (Jakub Skopal)

- DOM:
. Fixed use-after-free when re-constructing a DOMXPath whose php:function
registrations are freed while still reachable from the cycle collector.
Expand Down
3 changes: 3 additions & 0 deletions sapi/cli/php_cli_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2185,6 +2185,9 @@ static zend_result php_cli_server_begin_send_static(php_cli_server *server, php_
client->content_sender_initialized = true;
if (client->request.request_method != PHP_HTTP_HEAD) {
client->file_fd = fd;
} else {
/* Content-Length comes from the stat, the body is never sent. */
close(fd);
}

{
Expand Down
Loading