Fix GH-23764: Built-in server leaks fd on HEAD request for static file - #23765
Open
jakubskopal wants to merge 1 commit into
Open
jakubskopal wants to merge 1 commit into
jakubskopal wants to merge 1 commit into
Conversation
…file php_cli_server_begin_send_static() opens the file, but for HEAD requests never stores the descriptor in client->file_fd, so nothing closes it. Close it right away; Content-Length comes from the stat and the body is never sent, so the descriptor is not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-23764.
php_cli_server_begin_send_static()opens the file, but for HEAD requests never stores the descriptor inclient->file_fd, so nothing closes it. Close it right away;Content-Lengthcomes from the stat and the body is never sent, so the descriptor is not needed.Verified with a
--disable-allbuild: after 100curl -Irequests,/proc/<pid>/fdholds 0 references to the served file (previously 100); HEAD and GET responses unchanged.Bug exists since 8.2 (#8215); targeting PHP-8.4 as the lowest branch still receiving bug fixes.