Skip to content

ci: simplify translate workflow by using gh instead of peter-evans/create-pull-request #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dunglas wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −16
Open

ci: simplify translate workflow by using gh instead of peter-evans/create-pull-request #2237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions .github/workflows/translate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
uses: actions/checkout@v6
with:
fetch-depth: 0
Comment on lines 20 to 22
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing persist-credentials: false deviates from the convention used in every other workflow in this repo (see lint.yaml:26, tests.yaml:42, docker.yaml:58, static.yaml:69, windows.yaml:63, etc.). While this removal is necessary because git push needs credentials, consider adding a comment explaining why persist-credentials: false is intentionally omitted here, so future reviewers don't add it back and break the workflow.

Copilot uses AI. Check for mistakes.
persist-credentials: false
- id: md_files
run: |
FILES=$(git diff --name-only "${{ github.event.before }}" "${{ github.sha }}" -- 'docs/*.md')
Expand Down Expand Up @@ -51,19 +50,19 @@ jobs:
FIX_MARKDOWN: true
- name: Create Pull Request
if: steps.md_files.outputs.found == 'true'
uses: peter-evans/create-pull-request@v8
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
title: "docs: update translations"
commit-message: "docs: update translations"
committer: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
author: ${{ github.actor }} <${{ github.actor_id }}+${{ github.actor }}@users.noreply.github.com>
branch: translations/${{ github.run_id }}
delete-branch: true
body: |
Translation updates for: ${{ steps.md_files.outputs.files }}.
labels: |
translations
bot
draft: false
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
BRANCH="translations/${{ github.run_id }}"
git checkout -b "$BRANCH"
git add docs/
git diff --cached --quiet && exit 0
git commit -m "docs: update translations" --author="${{ github.actor }} <${{ github.actor_id }}+${{ github.actor }}@users.noreply.github.com>"
git push origin "$BRANCH"
gh pr create \
--title "docs: update translations" \
--body "Translation updates for: ${{ steps.md_files.outputs.files }}." \
--label "translations" \
--label "bot"
Loading