Skip to content

Fix circular dependency between BatchHandler and the renderer index #7373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavle-goloskokovic wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Fix circular dependency between BatchHandler and the renderer index #7373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/renderer/webgl/renderNodes/BatchHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ var Class = require('../../../utils/Class');
var ProgramManager = require('../ProgramManager');
var WebGLVertexBufferLayoutWrapper = require('../wrappers/WebGLVertexBufferLayoutWrapper');
var RenderNode = require('./RenderNode');
var Renderer = require('../../../renderer');
var RendererEvents = require('../../events');

/**
* @classdesc
Expand Down Expand Up @@ -129,7 +129,7 @@ var BatchHandler = new Class({

// Listen for changes to the number of draw calls per batch.
this.manager.on(
Renderer.Events.SET_PARALLEL_TEXTURE_UNITS,
RendererEvents.SET_PARALLEL_TEXTURE_UNITS,
this.updateTextureCount,
this
);
Expand Down Expand Up @@ -267,7 +267,7 @@ var BatchHandler = new Class({

// Set the dimension-related uniforms and listen for resize events.
this.resize(renderer.width, renderer.height);
renderer.on(Renderer.Events.RESIZE, this.resize, this);
renderer.on(RendererEvents.RESIZE, this.resize, this);
},

/**
Expand Down