Fix circular dependency between BatchHandler and the renderer index - #7373
Open
pavle-goloskokovic wants to merge 1 commit into
Open
Fix circular dependency between BatchHandler and the renderer index#7373pavle-goloskokovic wants to merge 1 commit into
pavle-goloskokovic wants to merge 1 commit into
Conversation
… renderer which causes circular dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Describe the changes below:
BatchHandlerrequires the whole renderer index just to read two event names fromRenderer.Events. Since the renderer index also (indirectly) requires the render nodes, this is a circular dependency, and whether it breaks depends on which side loads first.The existing builds happen to load the renderer index first, so they are fine. A custom build that loads
core/Gamefirst reachesBatchHandlerthroughRenderNodeManagerbefore the index.BatchHandlerthen pulls in the index, which loadsBatchHandlerQuad, which extends aBatchHandlerthat is still an empty object. The game fails at startup with "TypeError: Object prototype may only be an Object or null: undefined".Fix: require
renderer/eventsdirectly, asWebGLRenderer,WebGLPipelineandRenderTargetalready do. No behaviour change for the existing builds.