uv: declare workspace sources at root (fix geodude build in CI, #74)#75
Closed
siddhss5 wants to merge 1 commit into
Closed
uv: declare workspace sources at root (fix geodude build in CI, #74)#75siddhss5 wants to merge 1 commit into
siddhss5 wants to merge 1 commit into
Conversation
uv 0.11.x validates a member's `workspace = true` sources while building it and rejects them when the workspace context isn't established at the root, breaking `uv sync` (geodude -> mj-viser 'is not a workspace member'). The virtual root declared no [tool.uv.sources]; add the full member source map so inter-member deps resolve from the workspace authoritatively. Resolution is unchanged locally (uv.lock identical). Fixes #74.
Collaborator
Author
|
Closing — root-level sources were a misdiagnosis. The real root cause (confirmed via CI probe) is that the gitlink directories are empty in CI: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74. Candidate fix for the pre-existing
uv syncfailure (Failed to build geodude → mj-viser is not a workspace member).Diagnosis
setup-uv@v5) regression vs 0.7.3: it validates a member'sworkspace = truesources while building that member, and rejects them when the workspace source mapping isn't declared at the root.pyproject.tomldeclared no[tool.uv.sources]— each member declared its own — so building geodude failed.Fix
Declare the full member source map (
{ workspace = true }) at the workspace root. Resolution is unchanged locally (uv.lockidentical), so this is non-breaking.Verification is on this PR's CI: if the
integrationjob gets past the geodude build step, the fix holds.