Skip to content

Revert "Preserve authenticated scope in cached template lookups (#217)" - #734

Merged
nickdujay-pplx merged 1 commit into
mainfrom
revert-217-template-lookup-scope
Oct 20, 2026
Merged

nickdujay-pplx merged 1 commit into
mainfrom
revert-217-template-lookup-scope

Conversation

@nickdujay-pplx

Copy link
Copy Markdown
Collaborator

Reverts #217 (e03f0278).

Why

#217 has no mixed-version compatibility step. During a rolling upgrade, sandbox-manager and template-manager are separate DaemonSets, so a node can briefly run a new sandbox-manager next to an old template-manager. The new client requires a scope acknowledgement that the old server never sends. Template resolution on create and on restore then fails with FAILED_PRECONDITION "template lookup scope was not acknowledged" until both pods on that node are upgraded. The reverse pairing (old client, new server) mostly works, but every lookup goes to the catalog instead of the local cache.

We can't make every DaemonSet on a node reach the new version at the same moment, so this break would happen on every deploy that ships #217. We're reverting so the next release can go out safely. The change will come back in two phases:

  1. Compatible: servers always acknowledge a scope when one is sent and still accept requests without one. Clients send a scope, and if the acknowledgement is missing they log it, emit a metric, and fall back to today's behavior.
  2. Strict: once that metric reads zero across the fleet, make the acknowledgement required.

Conflict resolution

The revert conflicted with later changes, and those later changes are kept:

Testing

I didn't build this locally. CI is the compile and test gate.

AI assistance: Perplexity Computer prepared this revert and resolved the conflicts. A maintainer reviews it before merge.

@nickdujay-pplx
nickdujay-pplx marked this pull request as ready for review October 20, 2026 23:00
@nickdujay-pplx
nickdujay-pplx added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit c638f4d Oct 20, 2026
26 checks passed
@nickdujay-pplx
nickdujay-pplx deleted the revert-217-template-lookup-scope branch October 20, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants