Repository navigation
Prepare template lookup scope for rolling upgrades - #736
Merged
Merged
Conversation
nickdujay-pplx
force-pushed
the
codex/template-lookup-compatible-rollout
branch
from
October 21, 2026 18:32
688eee8 to
0fb8c4b
Compare
nickdujay-pplx
marked this pull request as ready for review
October 21, 2026 19:04
nickdujay-pplx
added a commit
that referenced
this pull request
Oct 21, 2026
Complete the compatibility protocol from public PR #736 for cold requests. Keep on-demand lookup metadata intact and retain cluster scope for background pulls. Add request-level regression coverage for digest and name-only lookups.
shrikant-pplx
approved these changes
Oct 21, 2026
shrikant-pplx
left a comment
Collaborator
There was a problem hiding this comment.
Re-reviewed 0b214e201 after the requested functional change.
- Root cause fixed: Yes.
- Every affected path covered: Yes.
- Changes remain focused: Yes.
- Tests reproduce the failure and cover important edges: Yes; CI is green.
- Introduced P0/P1 regression: No.
No P0/P1 findings remain.
Complete the compatibility protocol from public PR #736 for cold requests. Keep on-demand lookup metadata intact and retain cluster scope for background pulls. Add request-level regression coverage for digest and name-only lookups.
nickdujay-pplx
force-pushed
the
codex/template-lookup-compatible-rollout
branch
from
October 22, 2026 13:33
0b214e2 to
029b658
Compare
nickdujay-pplx
enabled auto-merge
October 22, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A rolling upgrade must keep template lookups working when client and server versions differ. The scope protocol reverted in #734 required an acknowledgement from servers that did not implement it. That can stop sandbox creation and restore during an otherwise normal upgrade.
This is the compatibility stage for replacing #217. It does not restore its stricter authorization rules.
Evidence
The incompatible pairing is a new lookup client with an old template-manager. The old server returns a valid template response without the new metadata. Rejecting that response makes successful lookups fail solely because of version skew. The reverse pairing must also retain existing cache and offline behavior.
Design
Clients send scope metadata through both cached and cold lookups. On-demand catalog resolution preserves the original scope, including legacy requests without scope; background and prefetch pulls use cluster scope. Servers preserve existing lookup and authorization decisions and return a separate receipt. Missing receipts retain legacy behavior; mismatched receipts fail. RPC errors are not retried without scope.
A receipt proves only that one peer received metadata. It is deliberately different from an authorization acknowledgement, so later enforcement cannot mistake this preparatory version for an enforcing server. No schema or placement change is included.
Validation
0fb8c4be8. Fresh CI is required for the review fix.Earlier validation also demonstrated all four pre-protocol/compatible binary pairings, cached offline behavior, and red/green create/restore request regressions when the strict missing-response rule was restored. It did not prove a completed mixed-version VM lifecycle.
Rollout
Deploy compatibility first. Inspect
auth.template_lookup.compatibilityacross participating services and exercise catalog lookups as well as cache hits. Zero legacy observations on an idle service is not proof of readiness. Strict authorization remains a separate follow-up with its own rollout and tests.Severity: availability regression during rolling upgrades. This preparatory PR does not claim to complete authorization hardening.
AI assistance: OpenAI Codex contributed the implementation, tests, and PR description.