Repository navigation
feat: phases B and C (type ratchet, bridge tests, a11y, generator, OnPush) - #609
Merged
Merged
Conversation
added 4 commits
October 1, 2026 15:36
…ents - noImplicitAny ratchet script with baseline; bridge files clean - FieldBase<TValue> generic (default any), markForCheck hook called by bridge - OnPush for 17 synchronous field components - characterization tests for AngularPConnectService and component map - refresh API report
…port type paths) build-overrides left 'import type' relative paths untouched, so the shipped field.base.ts in the overrides package could not resolve its import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phases B and C of the modernization plan, stacked on #608 (base is
chore/phase-a-modernization; retarget tomasterafter #608 merges). Seedocs/adr/0002-phase-b-c-outcomes.md.Phase B (additive)
noImplicitAnyper-file ratchet (npm run check:any);_bridgeis clean.FieldBase<TValue = any>generic (non-breaking) +markForCheck()hook called by the bridge.AngularPConnectServiceand the component map.npm run new:componentgenerator (scaffold +public-api.ts+ component-map registration).npm run check:overridestype-checks the generated overrides package. This found a real bug:build-overridesleftimport typerelative paths unrewritten, so the shippedfield.base.tsin@pega/angular-sdk-overridescould not resolve its import. Fixed.docs/components.md, plus testing and theming guides.Phase C (where verifiable without Infinity)
@defer, bridge split.Needs review before merge
OnPush changes are unit-tested but not exercised end-to-end (Playwright needs a Pega Infinity server). Please run MediaCo portal + embedded before merging.
Checklist
etc/angular-sdk-components.api.md)Validation
npm run lint— passednpm run build-angular-sdk-components— passednpm run test:unit— 131 passed, 43 skipped (legacy specs)npm run check:any,api:check,check:overrides,docs:components:check,smoke:pack— passednpm run build(test app) — passed