Repository navigation
chore: modernization (CI gates, API guard, type ratchet, bridge tests, a11y, generator, OnPush) - #608
Draft
ghoshArnab wants to merge 43 commits into
Draft
ghoshArnab wants to merge 43 commits into
ghoshArnab wants to merge 43 commits into
Conversation
4 tasks done
ghoshArnab
changed the title
ghoshArnab
force-pushed
the
chore/phase-a-modernization
branch
4 times, most recently
from
October 1, 2026 15:59
4938d67 to
fcc299f
Compare
added 8 commits
October 1, 2026 21:35
- *ngIf/*ngFor/ngSwitch to @if/@for/@switch across component templates - OnPush for synchronous field components and presentational components - FieldBase<TValue> generic (default any) and markForCheck() called by the bridge - takeUntilDestroyed for location and dashboard-filter subscriptions - type the bridge and component map for noImplicitAny
…s and a11y checks - global PCore/PConnect stand-ins, createMockChild, createMockActionsApi - stubComponentMapper and getMappedComponents for isolated component tests - _hooks.spec.ts loads first so single specs can be run with --include - 41 of 43 skipped specs restored (ListView and RootContainer keep specific TODOs) - new specs for CaseService, DatapageService, event-util, field-group-utils, Utils - characterization tests for the bridge service and component map - axe-core accessibility checks for 12 field components - karma coverage thresholds as a floor
- npm run verify: single check runner (--quick, --only, --json, --keep-going) - noImplicitAny per-file ratchet with baseline - public API report with api-extractor, tarball smoke test - overrides package type-check; build-overrides now rewrites import type paths - component catalogue generator and component scaffolding script - quality workflow for pull requests
…e setup - npm run configure applies SDK_* variables to sdk-config.json with validation - npm run doctor checks Node, dependencies, config, ports and Infinity reachability - Playwright base URL from SDK_E2E_BASE_URL, CI reporters, failure artifacts
…n helper - npm run changelog (add, new-release, release-date, check) preserves CHANGELOG.md format - npm run release:version sets the version in root, both packages and the lock file - changelog entries for this work
…p unused packages - Angular 21 family updated to 21.2.25; engines ^24.0.0; typescript ^5.9.3 - remove unused @angular/animations and @angular/material-experimental - Tiptap 3.31.4; husky 9 setup without the deprecated husky.sh sourcing - npm scripts for the new tooling; package metadata for both packages - quarterly grouped dependabot version updates
…and ADRs - guides for setup, sdk-config.json and SDK_* variables, CI-agnostic pipeline steps - customizing, theming, testing and troubleshooting guides; docs index - ADR 0001 (roadmap) and ADR 0002 (outcomes and deferred work, version constraints) - README quick start
…ency check - AGENTS.md start-here guide: verify loop, definition of done, recipes, pitfalls - CLAUDE.md, copilot-instructions, llms.txt, copilot-setup-steps workflow - eight custom agents, fifteen skills and prompts under .github - npm run check:agents validates front matter and referenced npm scripts
ghoshArnab
force-pushed
the
chore/phase-a-modernization
branch
from
October 1, 2026 16:06
fcc299f to
f41596e
Compare
added 14 commits
October 1, 2026 21:53
- use Angular's @angular/build:unit-test builder with Vitest on jsdom (no browser needed) - global hooks are now a setup file (src/test-hooks.ts); vitest.config.ts enables isolation - convert Jasmine APIs to Vitest (vi.fn, vi.spyOn, expect.objectContaining, rejects.toThrow) - rewrite the accessibility spec without a dynamic template (AOT compile) and add real specs for four previously empty spec files - coverage via v8 with thresholds in angular.json; drop Karma and Jasmine dependencies - remove the test app test target whose scaffold specs never compiled - update docs, skills, agents and instructions
Vitest stays on 4.x because @angular/build 21 supports ^4.0.8 only.
- ListView: builds its list context from engine metadata and loads data (supplied through PCore) - RootContainer: creates preview and modal containers, display-only handling, noPortal rendering - no unit tests are skipped any more; coverage thresholds raised to 34/31/34/32 - replace the unskip skill and prompt with guidance on strengthening placeholder specs
- add localizeText (non-deprecated localization service) and replace 22 getLocalizedValue calls - export localizeText from the public API and refresh the API report - enable @typescript-eslint/no-deprecated; Google AutocompleteService keeps a justified disable - use the observer form of RxJS subscribe and provideRouter in the test app - library build uses the @angular/build ng-packagr builder; @types/node 24.19 - update agent guidance and the changelog
Move prop resolution and form-field context cleanup into bridge helpers. Public service API and behaviour are unchanged.
Replace placeholder 'should create' specs for 28 field components with tests for config mapping, handlers, validation and display mode. Raise the coverage floor to match.
- SemanticLink: boolean visibility false now hides the link - Location: stored value shows on first render - RadioButtons: propName available during first update; mat-error shows - Multiselect: listType assigned so associated lists skip metadata - ListViewActionButtons: handle rejected submit - FieldBase: resolve actionsApi/propName before first update
Invoke the tooling scripts directly (node scripts/..., npx) from verify, CI, docs, agents and skills so package.json stays close to master.
The single agent routes by mode (build, fix, bridge, test, accessibility, docs, release, review, upgrade, customise, explain) and loads the skills.
Add repository knowledge, conventions, tooling, CI, mode workflows for build, fix, bridge, test, accessibility, docs, release, review, upgrade and customise, plus checklists, report formats, an error catalogue and glossary.
added 21 commits
October 2, 2026 01:24
This reverts commit d3beb6e.
copilot-setup-steps stays on ubuntu-latest, the runner the Copilot agent supports.
Delete the eight prompt files that duplicated agent modes. Add the binding constitution, the Spec Kit workflow, 2026 Angular 21 practices, working method and a risk and escalation matrix to the agent.
NavBar and WssNavBar rebuild navPages$ with new objects on every refresh. With @for tracking by reference the views were recreated after they had been checked when a store callback fired during change detection.
A store callback fired during change detection rebuilt childrenToRender and made the @for create views after their parent was checked (NG0100).
Store callbacks fired while Angular checks the view tree changed state the template had already been checked against, causing NG0100 with @for and @if in Stages, NavBar, DataReference and others. The bridge now defers such callbacks to a microtask and schedules a new pass for components that cannot mark themselves.
NG0100 came from views that were not refreshed after state changed outside Angular's event system: the dev-mode check pass then saw new state. The component mapper now gives components without markForCheck one backed by their ComponentRef, so the bridge's existing markForCheck call after store updates refreshes them, and DataReference flags its view when its datasource arrives. Reverts the bridge change-detection deferral, which did not address the cause.
The sdk-engineer agent already holds the other recipes. Update references.
Remove the new guides, ADRs, llms.txt and the generated component catalogue with its generator and check; restore README and CONTRIBUTING. Update references in AGENTS.md, the agent and tooling.
…gineer agent Fold the former getting-started, configuration, theming and troubleshooting guides into the agent as Onboard, Theming and Troubleshoot modes with checks, method, evidence collection and a runtime error catalogue.
Order the parts by purpose (principles, facts, router, modes, cross-cutting practice, reference), renumber with consistent cross references, and add a retrieval guide, critical rules, a question index, a table of contents and a use-when and keywords line for every part. No content removed.
Add Part 14: boundary and component contract, integration levels, discovery and gap analysis, token and brand layer, per-component override with a worked example, adapter layer for a family, design-language checklist, tokens pipeline, governance, migration plan, verification and anti-patterns. Renumber the later parts and update the router, index and table of contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository modernization for customers who clone and customise this repo, with an agent-assisted workflow. Everything is additive for consumers of
@pega/angular-sdk-componentsand@pega/angular-sdk-overridesunless noted.Library and components
*ngIf/*ngFormigrated to@if/@for; OnPush for synchronous field and presentational components;FieldBase<TValue = any>with amarkForCheck()hook the bridge calls after store updates.localizeTextreplacesgetLocalizedValue) and enforced with@typescript-eslint/no-deprecated._bridge/helpers; characterization tests added.listType, ListViewActionButtons rejected submit, RootContainer "Missing: undefined" flash, ListView column ids, NavBar/WssNavBar page tracking).^5.9.3; unused@angular/animationsand@angular/material-experimentalremoved; Tiptap 3.31.4; Husky v9.Tests and tooling
@angular/build:unit-test(jsdom); about 630 tests, coverage floor raised; behaviour tests for the field components.node scripts/verify.js(one command for all CI checks), public API report (api-extractor),noImplicitAnyper-file ratchet, overrides type-check, tarball smoke test,scripts/new-component.js,scripts/configure-sdk.js, changelog and release-version tooling (existingCHANGELOG.mdformat and manual release process kept)..github/workflows/quality.ymlruns onubuntu-24.04-armwith current action majors; Dependabot runs quarterly.Agent
sdk-engineeragent (.github/agents/),AGENTS.md,copilot-setup-steps.yml, and thesdk-pconnect-apiskill alongside the existing Spec Kit skills.Not verified
Playwright E2E (needs a Pega Infinity server) was not run. Rendering-affecting changes (OnPush, animations removal,
localizeText, theFieldBaseinit order, MultiselectlistType) should be checked in the MediaCo portal and embedded flows before merging.Follow-ups (for later PRs)
FieldBase.getErrorMessageand the rich-textaria-labels are hard-coded English; templates and widgets lack ARIA and axe tests.noImplicitAnybaseline: about 1,000 errors inscripts/implicit-any-baseline.json.shouldComponentUpdateinto services, after more characterization tests.inject(), 66::ng-deepuses,@angular/material-moment-adapterin date fields, CI unit tests take about 3 minutes (per-file jsdom and setup cost).AutocompleteServicemigration, test app to the esbuild builder,@pega/pcore-pconnect-typedefs5.x, and a future major (signal inputs,@defer, secondary entry points, Angular 22 with Vitest 5).