Skip to content

Raise room-envelope height caps from 6m to 20m #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass08 merged 1 commit into from
Aug 12, 2026
Merged

Raise room-envelope height caps from 6m to 20m #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/editor/src/components/ui/floating-level-selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ function LevelRow({
>
<SliderControl
label="Level height"
max={6}
max={20}
min={1}
onChange={(v) => updateNode(level.id, { height: v })}
precision={3}
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes/src/ceiling/panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ export function CeilingPanel() {
) : (
<SliderControl
label="Height"
max={Math.min(6, maxHeight)}
max={Math.min(20, maxHeight)}
min={0}
onChange={handleHeightChange}
precision={3}
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes/src/ceiling/parametrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const ceilingParametrics: ParametricDescriptor<CeilingNode> = {
groups: [
{
label: 'Dimensions',
fields: [{ key: 'height', kind: 'number', unit: 'm', min: 1.5, max: 6, step: 0.05 }],
fields: [{ key: 'height', kind: 'number', unit: 'm', min: 1.5, max: 20, step: 0.05 }],
},
],
customPanel: () => import('./panel'),
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes/src/column/panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ export default function ColumnPanel() {
)}
<SliderControl
label="Height"
max={6}
max={20}
min={0.8}
onChange={(value) => handleUpdate({ height: value })}
precision={2}
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes/src/column/parametrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const columnParametrics: ParametricDescriptor<ColumnNode> = {
{
label: 'Dimensions',
fields: [
{ key: 'height', kind: 'number', unit: 'm', min: 0.5, max: 6, step: 0.05 },
{ key: 'height', kind: 'number', unit: 'm', min: 0.5, max: 20, step: 0.05 },
{ key: 'width', kind: 'number', unit: 'm', min: 0.1, max: 2, step: 0.01 },
{ key: 'depth', kind: 'number', unit: 'm', min: 0.1, max: 2, step: 0.01 },
],
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes/src/wall/panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,11 +287,11 @@ export default function WallPanel() {
) : (
<SliderControl
label="Height"
max={metersToLinearUnit(6, unit)}
max={metersToLinearUnit(20, unit)}
min={metersToLinearUnit(0.1, unit)}
onChange={(v) =>
handleUpdate({
height: linearControlValueToMeters(v, unit, { maxMeters: 6, minMeters: 0.1 }),
height: linearControlValueToMeters(v, unit, { maxMeters: 20, minMeters: 0.1 }),
})
}
precision={2}
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes/src/wall/parametrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const wallParametrics: ParametricDescriptor<WallNode> = {
{ key: 'thickness', kind: 'number', unit: 'm', min: 0.05, max: 0.6, step: 0.01 },
// `height` may be absent (plane-bound top); the custom panel owns the
// Follows storey / Custom height mode switch, so this is metadata only.
{ key: 'height', kind: 'number', unit: 'm', min: 1.5, max: 6, step: 0.05 },
{ key: 'height', kind: 'number', unit: 'm', min: 1.5, max: 20, step: 0.05 },
{ key: 'curveOffset', kind: 'number', unit: 'm', min: -3, max: 3, step: 0.05 },
],
},
Expand Down
Loading