[FSSDK-12028] add ttl to events in event store #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raju-opti
force-pushed
the
raju/event_store_ttl
branch
from
7f88191 to
ebb53a8
Compare
junaed-optimizely
approved these changes
Nov 12, 2025
Contributor
junaed-optimizely
left a comment
junaed-optimizely
left a comment
There was a problem hiding this comment.
Looks solid to me. I do not see any blocking concerns.
raju-opti
force-pushed
the
raju/event_store_ttl
branch
from
ebb53a8 to
a9baffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add configurable ttl support to stored events. This will be helpful if for some reason, events are failing permanently (for example, the event enpoint is blocked by adblocker/isp).
Also, refactored the code to move the responsibility of limiting the number of saved event to the store implementation from the event processor.
Test plan
Issues