up

Author: raju-opti

lib/event_processor/batch_event_processor.ts

@@ -39,7 +39,6 @@ export const MAX_EVENTS_IN_STORE = 500;
 export type EventWithId = {
   id: string;
   event: ProcessableEvent;
-  // notStored?: boolean;
 };
 
 export type RetryConfig = {
@@ -92,7 +91,6 @@ export class BatchEventProcessor extends BaseService implements EventProcessor {
     this.dispatchRepeater = config.dispatchRepeater;
     this.dispatchRepeater.setTask(() => this.flush());
 
-    // this.maxEventsInStore = Math.max(2 * config.batchSize, MAX_EVENTS_IN_STORE);
     this.failedEventRepeater = config.failedEventRepeater;
     this.failedEventRepeater?.setTask(() => this.retryFailedEvents());
     if (config.logger) {

lib/event_processor/event_processor_factory.ts

@@ -16,15 +16,15 @@
 
 import { LogLevel } from "../logging/logger";
 import { StartupLog } from "../service";
+import { AsyncPrefixStore, Store, SyncPrefixStore } from "../utils/cache/store";
+import { validateStore } from "../utils/cache/store_validator";
 import { ExponentialBackoff, IntervalRepeater } from "../utils/repeater/repeater";
+import { Maybe } from "../utils/type";
+import { BatchEventProcessor, DEFAULT_MAX_BACKOFF, DEFAULT_MIN_BACKOFF, EventWithId, RetryConfig } from "./batch_event_processor";
 import { EventDispatcher } from "./event_dispatcher/event_dispatcher";
 import { EventProcessor } from "./event_processor";
+import { EVENT_STORE_PREFIX } from "./event_store";
 import { ForwardingEventProcessor } from "./forwarding_event_processor";
-import { BatchEventProcessor, DEFAULT_MAX_BACKOFF, DEFAULT_MIN_BACKOFF, EventWithId, RetryConfig } from "./batch_event_processor";
-import { AsyncPrefixStore, Store, SyncPrefixStore } from "../utils/cache/store";
-import { Maybe } from "../utils/type";
-import { validateStore } from "../utils/cache/store_validator";
-import { DEFAULT_MAX_EVENTS_IN_STORE, EVENT_STORE_PREFIX, EventStore } from "./event_store";
 
 export const INVALID_EVENT_DISPATCHER = 'Invalid event dispatcher';
 

lib/event_processor/event_store.spec.ts

@@ -21,7 +21,7 @@ import { createImpressionEvent } from '../tests/mock/create_event';
 
 import { DEFAULT_MAX_EVENTS_IN_STORE } from './event_store';
 import { exhaustMicrotasks } from '../tests/testUtils';
-import { EVENT_STORE_FULL } from '../message/log_message';
+import { EVENT_STORE_FULL } from 'error_message';
 import { OptimizelyError } from '../error/optimizly_error';
 
 type TestStoreConfig = {

lib/event_processor/event_store.ts

@@ -1,10 +1,17 @@
-import { EventWithId } from "./batch_event_processor";
-import { AsyncPrefixStore, AsyncStore, AsyncStoreWithBatchedGet, Store, StoreWithBatchedGet, SyncPrefixStore } from "../utils/cache/store";
-import { Maybe } from "../utils/type";
-import { SerialRunner } from "../utils/executor/serial_runner";
-import { LoggerFacade } from "../logging/logger";
-import { EVENT_STORE_FULL } from "../message/log_message";
 import { OptimizelyError } from "../error/optimizly_error";
+import { LoggerFacade } from "../logging/logger";
+import { EVENT_STORE_FULL } from "error_message";
+import {
+  AsyncPrefixStore,
+  AsyncStore, 
+  AsyncStoreWithBatchedGet, 
+  Store,
+  StoreWithBatchedGet,
+  SyncPrefixStore
+} from "../utils/cache/store";
+import { SerialRunner } from "../utils/executor/serial_runner";
+import { Maybe } from "../utils/type";
+import { EventWithId } from "./batch_event_processor";
 
 export type StoredEvent = EventWithId & {
   expiresAt?: number;
@@ -80,7 +87,6 @@ export class EventStore extends AsyncStoreWithBatchedGet<EventWithId> implements
     // readKeys might have failed, in that case we cannot enforce max size
     // that means, the store might grow beyond max size in failure scenarios
     if (this.keys !== undefined && this.keys.size >= this.maxSize) {
-      this.logger?.info(EVENT_STORE_FULL, event.event.uuid);
       return Promise.reject(new OptimizelyError(EVENT_STORE_FULL, event.event.uuid));
     }
 

lib/message/error_message.ts

@@ -96,5 +96,6 @@ export const CMAB_FETCH_FAILED = 'CMAB decision fetch failed with status: %s';
 export const INVALID_CMAB_FETCH_RESPONSE = 'Invalid CMAB fetch response';
 export const PROMISE_NOT_ALLOWED = "Promise value is not allowed in sync operation";
 export const SERVICE_NOT_RUNNING = "%s not running";
+export const EVENT_STORE_FULL = 'Event store is full. Not saving event with id %d.';
 
 export const messages: string[] = [];

lib/message/log_message.ts

@@ -60,7 +60,6 @@ export const USER_HAS_NO_FORCED_VARIATION_FOR_EXPERIMENT =
   'No experiment %s mapped to user %s in the forced variation map.';
 export const INVALID_EXPERIMENT_KEY_INFO =
   'Experiment key %s is not in datafile. It is either invalid, paused, or archived.';
-export const EVENT_STORE_FULL = 'Event store is full. Not saving event with id %d.';
 export const IGNORE_CMAB_CACHE = 'Ignoring CMAB cache for user %s and rule %s.';
 export const RESET_CMAB_CACHE = 'Resetting CMAB cache for user %s and rule %s.';
 export const INVALIDATE_CMAB_CACHE = 'Invalidating CMAB cache for user %s and rule %s.';