Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
http-client:
type: string
required: false
default: 'vertx'
default: 'vertx-5'
experimental:
type: boolean
required: false
Expand Down
37 changes: 37 additions & 0 deletions docs/content/en/docs/migration/v5-7-migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,40 @@ Other notable Jackson 3 differences:
```java
client.pods().withShardSelector((String) null);
```

## Default HTTP client is now Vert.x 5

The `operator-framework` artifact now brings the Vert.x 5 based HTTP client of the Fabric8 client
(`kubernetes-httpclient-vertx-5`), which is also the default of the Fabric8 client itself, instead of
the JDK one (`kubernetes-httpclient-jdk`). If your operator doesn't declare an HTTP client
implementation of its own there is nothing to do, it gets the new default. To keep using the JDK
client, or to use another implementation, exclude the default from the `operator-framework`
dependency and add the one you want:

```xml
<dependency>
<groupId>io.javaoperatorsdk</groupId>
<artifactId>operator-framework</artifactId>
<exclusions>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-httpclient-vertx-5</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-httpclient-jdk</artifactId>
Comment thread
csviri marked this conversation as resolved.
Resolved
<version>8.0.0</version>
</dependency>
```

The implementations provided as part of the Fabric8 client all follow the
`kubernetes-httpclient-<implementation name>` pattern for their artifact identifier.

If your operator already replaced the default HTTP client, update the exclusion: excluding
`kubernetes-httpclient-jdk` no longer has any effect and `kubernetes-httpclient-vertx-5` would end up
on the classpath next to your implementation. This is especially important if you use the Vert.x 4
based client (`kubernetes-httpclient-vertx`), since Vert.x 4 and Vert.x 5 cannot be used together.
If you want to keep the Vert.x 4 based client, use it in place of `kubernetes-httpclient-jdk` in the
snippet above.
2 changes: 1 addition & 1 deletion micrometer-support/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
</dependency>
<dependency>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-httpclient-vertx</artifactId>
<artifactId>kubernetes-httpclient-${fabric8-httpclient-impl.name}</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
<maven.compiler.release>${java.version}</maven.compiler.release>
<sonar.organization>java-operator-sdk</sonar.organization>
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
<fabric8-httpclient-impl.name>jdk</fabric8-httpclient-impl.name>
<fabric8-httpclient-impl.name>vertx-5</fabric8-httpclient-impl.name>
<junit.version>6.1.3</junit.version>
<fabric8-client.version>8.0.0</fabric8-client.version>
<slf4j.version>2.0.20</slf4j.version>
Expand Down
4 changes: 0 additions & 4 deletions sample-operators/tomcat-operator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-httpclient-vertx</artifactId>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j2-impl</artifactId>
Expand Down
Loading