Repository navigation
feat: use the Vert.x HTTP client of the Fabric8 client by default - #3674
Merged
Merged
Conversation
The operator-framework artifact now brings kubernetes-httpclient-vertx-5, the default of the Fabric8 client itself, instead of kubernetes-httpclient-jdk. The migration guide describes how to keep using the JDK client. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The migration recipe omits the Fabric8 dependency version, causing Maven validation to fail in bootstrapper-generated projects that import only the JOSDK BOM.
1 open issue
What changed in this PR
Switches the SDK’s default Fabric8 HTTP client from JDK to Vert.x 5, aligning it with Fabric8’s default.
Changes:
- Updates the shared HTTP client selection to
vertx-5. - Documents how operators can retain the JDK client or choose another implementation.
| File | Description |
|---|---|
pom.xml |
Selects Vert.x 5 as the default HTTP client. |
docs/content/en/docs/migration/v5-7-migration.md |
Explains the default change and provides dependency replacement instructions. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
The tomcat sample and micrometer-support explicitly depended on kubernetes-httpclient-vertx (Vert.x 4), which clashed with kubernetes-httpclient-vertx-5 now brought by operator-framework. Drop the explicit dependency from the sample and make micrometer-support follow the fabric8-httpclient-impl.name property. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ation guide The integration-tests workflow defaulted to the Vert.x 4 based client, so runs that did not pass http-client did not exercise the new default. The migration guide now names Vert.x 5 in the heading and explains how to update an exclusion of the previous default client. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
csviri
added a commit
that referenced
this pull request
Nov 6, 2026
) * feat: use the Vert.x HTTP client of the Fabric8 client by default The operator-framework artifact now brings kubernetes-httpclient-vertx-5, the default of the Fabric8 client itself, instead of kubernetes-httpclient-jdk. The migration guide describes how to keep using the JDK client. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: use the Vert.x HTTP client of the Fabric8 client by default
Changes the HTTP client implementation
operator-frameworkbrings by default from the JDK one(
kubernetes-httpclient-jdk) to the Vert.x 5 one (kubernetes-httpclient-vertx-5), which is alsothe default of the Fabric8 client itself.
What changes
fabric8-httpclient-impl.nameproperty of the rootpom.xmlis nowvertx-5(wasjdk).operator-framework, the sample operators and the test scope ofoperator-framework-corepicktheir client through it.
operator-framework-corekeeps excluding the Fabric8 default fromkubernetes-client, so thatexactly one implementation is on the classpath, the one selected by the property.
one: exclude
kubernetes-httpclient-vertx-5fromoperator-frameworkand add the implementationyou want.
Impact
Operators that get their HTTP client transitively from
operator-frameworkand don't declare onethemselves now get Vert.x instead of the JDK client. Operators that declare an implementation of
their own are not affected, as before they need to exclude the default one.
The CI already runs the integration tests with the
vertx-5,jdkandjettyclients (thehttpclient-testsmatrix passes the client explicitly), so this does not change what is tested.The JDK default dates from #2235 (Feb 2024).