Skip to content

Use AES Ceph cipher for CentOS-9 HCI scenario - #4144

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fultonj:cent9_hci_aes
Aug 26, 2026
Merged

Use AES Ceph cipher for CentOS-9 HCI scenario#4144
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fultonj:cent9_hci_aes

Conversation

@fultonj

@fultonj fultonj commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Update scenarios/centos-9/hci_ceph_backends.yml so that jobs which depend on that file use the Ceph old AES cipher and not the new AES256k cipher.

@fultonj @rebtoor @cursoragent
Use AES Ceph cipher for CentOS-9 HCI scenario
3be9833 
Update scenarios/centos-9/hci_ceph_backends.yml so that jobs
which depend on that file use the Ceph old AES cipher and not
the new AES256k cipher.

Co-authored-by: Roberto Alfieri <ralfieri@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: John Fulton <fulton@redhat.com>
@qodo-code-review

qodo-code-review Bot commented Aug 25, 2026

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@fultonj
fultonj requested review from fmount, rebtoor and tosky August 25, 2026 19:33
@fultonj fultonj mentioned this pull request Aug 25, 2026
Open
fmount
fmount approved these changes Aug 25, 2026
View reviewed changes

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this change because I think we are not going to rebuild Antelope clients to include a new ceph-common (if available) from centos storage sig. iirc Antelope goes with squid clients, and we need backports for it before switching to the new defaults, so this makes sense to me.
I was under impression that this was already covered by #4130, but I might be wrong and I might need to investigate more.
Being that said, the change of this patch makes sense and /lgtm

@rebtoor

rebtoor commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

I'm ok with this change because I think we are not going to rebuild Antelope clients to include a new ceph-common (if available) from centos storage sig. iirc Antelope goes with squid clients, and we need backports for it before switching to the new defaults, so this makes sense to me. I was under impression that this was already covered by #4130, but I might be wrong and I might need to investigate more. Being that said, the change of this patch makes sense and /lgtm

https://github.com/rebtoor/ci-framework/blob/c07d8d4f7727303ceccc711beb282ccb51374fe2/scenarios/centos-9/hci_ceph_backends.yml#L18-L19

I changed those values as well but it's not important. I'm fine with the gradual approach. lgtm from me as well.

@rebtoor

rebtoor commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Aug 26, 2026
@fmount

fmount commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

/approve

@fyanac fyanac mentioned this pull request Aug 26, 2026
Open
Valkyrie00
Valkyrie00 approved these changes Aug 26, 2026
View reviewed changes

@Valkyrie00 Valkyrie00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Valkyrie00

Valkyrie00 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, Valkyrie00

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 50f35b6 into openstack-k8s-operators:main Aug 26, 2026
9 checks passed
@rebtoor rebtoor mentioned this pull request Aug 26, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmount fmount fmount approved these changes
@Valkyrie00 Valkyrie00 Valkyrie00 approved these changes
@rebtoor rebtoor Awaiting requested review from rebtoor
@tosky tosky Awaiting requested review from tosky

Assignees

@rebtoor rebtoor

@Valkyrie00 Valkyrie00

Labels

approved lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fultonj @rebtoor @fmount @Valkyrie00