[edpm_deploy_baremetal] Wait for ProvisionServer localImageUrl - #4136
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
775b98b to
896aff8
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 13m 54s |
|
recheck |
|
This change depends on a change that failed to merge. Change #4130 is needed. |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nemarjan, Valkyrie00 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
896aff8 to
41a14d3
Compare
The role queried OpenStackProvisionServer status as soon as the deployment was Available, but the baremetal operator sets status.localImageUrl asynchronously. Retry k8s_info until the URL is present and use dict.get() when building checksum fallback facts. Seen in cifmw-crc-podified-edpm-baremetal-bootc while validating ci-framework#4131 (unrelated failure). Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
0c11976
41a14d3 to
0c11976
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
too many unrelated fails. /override rdoproject.org/github-check |
|
@rebtoor: Overrode contexts on behalf of rebtoor: rdoproject.org/github-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
Ack and agreed |
e04cbb8
into
openstack-k8s-operators:main
4 participants
Summary
OpenStackProvisionServeruntilstatus.localImageUrlis set..get()access when deriving the checksum URL fallback.Problem
cifmw-crc-podified-edpm-baremetal-bootcfailed inedpm_deploy_baremetalwith
'dict object' has no attribute 'localImageUrl'even though theProvision Server pod and deployment were ready. The operator publishes
localImageUrlafter reconciliation, not when the Deployment becomesAvailable.
Test plan
cifmw-crc-podified-edpm-baremetal-bootcon rdoproject ZuulTEST_SINGLE_ROLE=edpm_deploy_baremetal make molecule(dry-run converge)Made with Cursor