Skip to content

update art configuration for oadp-1.6#2132

Merged
weshayutin merged 2 commits intoopenshift:oadp-1.6from
weshayutin:artoadp16
Mar 25, 2026
Merged

update art configuration for oadp-1.6#2132
weshayutin merged 2 commits intoopenshift:oadp-1.6from
weshayutin:artoadp16

Conversation

@weshayutin
Copy link
Contributor

Why the changes were made

following the oadp-1.5 pattern and do what @rayfordj tells me to do

How to test the changes made

pray for builds son :)

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@openshift-ci openshift-ci bot requested review from mpryc and mrnold March 23, 2026 22:48
@weshayutin
Copy link
Contributor Author

/cherry-pick oadp-dev

@openshift-cherrypick-robot
Copy link
Contributor

@weshayutin: once the present PR merges, I will cherry-pick it on top of oadp-dev in a new PR and assign it to you.

Details

In response to this:

/cherry-pick oadp-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 23, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cefe58d2-ceef-4f2d-a4a7-cd8d41a5380f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

rayfordj
rayfordj previously approved these changes Mar 23, 2026
Copy link
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2026
from:
kind: DockerImage
name: quay.io/konveyor/oadp-vmfr-access-filebrowser:oadp-1.6
- name: oadp-cli-binaries-rhel9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rayfordj does the schema allow for two images per repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one or many; as far as I'm aware, care not from which repo they are built only that the pullspec are correct for the replacement of "upstream" to "downstream".

Also, any missing or inaccurate config will almost certainly surface as a build failure down the line, so ... there's always that backstop to discovery 😆

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2026
@rayfordj
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2026
@mpryc
Copy link
Contributor

mpryc commented Mar 25, 2026

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc, rayfordj, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,mpryc,rayfordj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weshayutin weshayutin merged commit a946aa9 into openshift:oadp-1.6 Mar 25, 2026
8 of 16 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@weshayutin: new pull request created: #2135

Details

In response to this:

/cherry-pick oadp-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants