update art configuration for oadp-1.6#2132
Conversation
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
/cherry-pick oadp-dev |
|
@weshayutin: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| from: | ||
| kind: DockerImage | ||
| name: quay.io/konveyor/oadp-vmfr-access-filebrowser:oadp-1.6 | ||
| - name: oadp-cli-binaries-rhel9 |
There was a problem hiding this comment.
We will need as well:
https://quay.io/repository/konveyor/oadp-vmdp-binaries?tab=tags
There was a problem hiding this comment.
@rayfordj does the schema allow for two images per repo?
There was a problem hiding this comment.
one or many; as far as I'm aware, care not from which repo they are built only that the pullspec are correct for the replacement of "upstream" to "downstream".
Also, any missing or inaccurate config will almost certainly surface as a build failure down the line, so ... there's always that backstop to discovery 😆
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mpryc, rayfordj, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@weshayutin: new pull request created: #2135 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why the changes were made
following the oadp-1.5 pattern and do what @rayfordj tells me to do
How to test the changes made
pray for builds son :)