Skip to content

[release-coo-ocp-4.15] TRACING-6116: Add TLS min version and cipher suite configuration support#259

Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:release-coo-ocp-4.15from
openshift-cherrypick-robot:cherry-pick-258-to-release-coo-ocp-4.15
May 6, 2026
Merged

[release-coo-ocp-4.15] TRACING-6116: Add TLS min version and cipher suite configuration support#259
openshift-merge-bot[bot] merged 5 commits intoopenshift:release-coo-ocp-4.15from
openshift-cherrypick-robot:cherry-pick-258-to-release-coo-ocp-4.15

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #258

/assign openshift-cherrypick-robot

/cherrypick release-coo-ocp-4.12

ozzywalsh added 5 commits May 6, 2026 09:36
Add --tls-min-version and --tls-cipher-suites flags with env var
fallback (TLS_MIN_VERSION, TLS_CIPHER_SUITES). Uses k8s component-base
for TLS version and cipher suite validation, matching the approach in
the opentelemetry-operator. Defaults to TLS 1.2 when no min version is
specified.
Simplify TLS cipher suites flag handling by using a plain string flag
instead of a custom flag.Value type. The operator is expected to provide
valid values, so whitespace trimming is unnecessary.
Previously errors from k8sapiflag.TLSVersion and TLSCipherSuites were
silently discarded when configuring the proxy TLS settings. This adds
fatal error logging consistent with how the server TLS config handles
parse failures.
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 6, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: TRACING-6116

Details

In response to this:

This is an automated cherry-pick of #258

/assign openshift-cherrypick-robot

/cherrypick release-coo-ocp-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f40fe1e0-7a73-4a57-b429-b2bd57826b5c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from IshwarKanse and zhuje May 6, 2026 09:37
@andreasgerstmayr
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026
@IshwarKanse
Copy link
Copy Markdown
Member

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label May 6, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 6, 2026

@openshift-cherrypick-robot: This pull request references TRACING-6116 which is a valid jira issue.

Details

In response to this:

This is an automated cherry-pick of #258

/assign openshift-cherrypick-robot

/cherrypick release-coo-ocp-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 6, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 4611874 into openshift:release-coo-ocp-4.15 May 6, 2026
6 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown
Author

@openshift-cherrypick-robot: #259 failed to apply on top of branch "release-coo-ocp-4.12":

Applying: Add TLS min version and cipher suite configuration support
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	pkg/server.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/server.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add TLS min version and cipher suite configuration support

Details

In response to this:

This is an automated cherry-pick of #258

/assign openshift-cherrypick-robot

/cherrypick release-coo-ocp-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants