[release-coo-ocp-4.12] TRACING-6116: Add TLS min version and cipher suite configuration support#260
Conversation
Add --tls-min-version and --tls-cipher-suites flags with env var fallback (TLS_MIN_VERSION, TLS_CIPHER_SUITES). Uses k8s component-base for TLS version and cipher suite validation, matching the approach in the opentelemetry-operator. Defaults to TLS 1.2 when no min version is specified.
Simplify TLS cipher suites flag handling by using a plain string flag instead of a custom flag.Value type. The operator is expected to provide valid values, so whitespace trimming is unnecessary.
Previously errors from k8sapiflag.TLSVersion and TLSCipherSuites were silently discarded when configuring the proxy TLS settings. This adds fatal error logging consistent with how the server TLS config handles parse failures.
openshift-ci-robot
added
the
jira/valid-reference
|
@ozzywalsh: This pull request references TRACING-6116 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @ozzywalsh. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreasgerstmayr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
|
@ozzywalsh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label qe-approved |
openshift-ci
Bot
added
the
qe-approved
openshift-merge-bot
Bot
merged commit d5df367
into
openshift:release-coo-ocp-4.12
4 participants
This is a manual cherry-pick of #259 to release-coo-ocp-4.12.
The automated cherry-pick failed due to merge conflicts in
go.modandgo.sum. Conflicts were resolved by keeping the 4.12 dependency versions and runninggo mod tidy./assign andreasgerstmayr