Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dynamic-demo-plugin/i18next.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default defineConfig({
input: 'src/**/*.{js,jsx,ts,tsx}',
output: 'locales/{{language}}/{{namespace}}.json',

defaultValue: (key) => key,
defaultValue: (key) => key.replace(/_(?:one|other)$/, ''),
sort: true,
keySeparator: false,
nsSeparator: '~',
Expand Down
3 changes: 1 addition & 2 deletions dynamic-demo-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
"build-rspack": "BUNDLER=rspack yarn ts-node node_modules/.bin/rspack -c webpack.config.ts",
"build": "yarn clean && NODE_ENV=production yarn build-rspack && NODE_ENV=production yarn build-webpack",
"build-dev": "yarn clean && yarn build-rspack && yarn build-webpack",
"build-plugin-sdk": "yarn --cwd ../frontend build-plugin-sdk && yarn install-plugin-sdk",
"install-plugin-sdk": "rm -rf node_modules/@openshift-console && yarn install",
"build-plugin-sdk": "yarn --cwd ../frontend/packages/console-dynamic-plugin-sdk build",
"start-console": "./start-console.sh",
"http-server": "./http-server.sh dist",
"i18n": "i18next-cli lint && i18next-cli extract",
Expand Down
5 changes: 5 additions & 0 deletions frontend/e2e/tests/knative/serverless/knative-ci.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { execFileSync } from 'child_process';

import { test, expect } from '../../../fixtures';
import { warmupSPA } from '../../../pages/base-page';
import { AddFlowPage } from '../../../pages/knative/add-flow-page';
import { AdminEventingPage } from '../../../pages/knative/admin-eventing-page';
import { TopologyKnativePage } from '../../../pages/knative/topology-knative-page';
Expand Down Expand Up @@ -35,6 +36,10 @@ test.describe(
} catch { /* ignore on OCP 4 */ }
});

test.beforeEach(async ({ page }) => {
await warmupSPA(page);
});

test.afterAll(async () => {
await k8sClient.deleteNamespace(namespace);
});
Expand Down
5 changes: 5 additions & 0 deletions frontend/e2e/tests/webterminal/web-terminal-config.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { test, expect } from '../../fixtures';
import { warmupSPA } from '../../pages/base-page';
import { WebTerminalConfigPage } from '../../pages/web-terminal-config-page';
import {
ensureWebTerminalOperatorInstalled,
Expand All @@ -15,6 +16,10 @@ test.describe('Customization of web terminal options', () => {
await ensureWebTerminalOperatorInstalled(k8sClient);
});

test.beforeEach(async ({ page }) => {
await warmupSPA(page);
});

test.afterAll(async ({ k8sClient }) => {
await uninstallWebTerminalOperator(k8sClient);
});
Expand Down
2 changes: 1 addition & 1 deletion frontend/i18next.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default defineConfig({
);
},

defaultValue: (key) => key, // namespace should not be included in the default value
defaultValue: (key) => key.replace(/_(?:one|other)$/, ''),
sort: true,
keySeparator: false,
nsSeparator: '~',
Expand Down
6 changes: 4 additions & 2 deletions frontend/packages/console-app/locales/en/console-app.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,10 @@
"API Servers": "API Servers",
"API version": "API version",
"Applications": "Applications",
"Applies to {{nodeCount}} selected nodes that are currently unschedulable.": "Applies to {{nodeCount}} selected nodes that are currently unschedulable.",
"Applies to {{nodeCount}} selected nodes that are schedulable.": "Applies to {{nodeCount}} selected nodes that are schedulable.",
"Applies to {{count}} selected nodes that are currently unschedulable._one": "Applies to {{count}} selected node that is currently unschedulable.",
"Applies to {{count}} selected nodes that are currently unschedulable._other": "Applies to {{count}} selected nodes that are currently unschedulable.",
"Applies to {{count}} selected nodes that are schedulable._one": "Applies to {{count}} selected node that is schedulable.",
"Applies to {{count}} selected nodes that are schedulable._other": "Applies to {{count}} selected nodes that are schedulable.",
"Approval required": "Approval required",
"Approve": "Approve",
"Architecture": "Architecture",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,9 @@ export const useCustomNodeActions = ({
onClick={handleMarkSchedulable}
isDisabled={inProgress}
data-test="bulk-mark-schedulable"
description={t(
'Applies to {{nodeCount}} selected nodes that are currently unschedulable.',
{ nodeCount: unschedulableCount },
)}
description={t('Applies to {{count}} selected nodes that are currently unschedulable.', {
count: unschedulableCount,
})}
>
{t('Mark schedulable')}
</DropdownItem>,
Expand All @@ -75,8 +74,8 @@ export const useCustomNodeActions = ({
onClick={handleMarkUnschedulable}
isDisabled={inProgress}
data-test="bulk-mark-unschedulable"
description={t('Applies to {{nodeCount}} selected nodes that are schedulable.', {
nodeCount: schedulableCount,
description={t('Applies to {{count}} selected nodes that are schedulable.', {
count: schedulableCount,
})}
>
{t('Mark unschedulable')}
Expand Down