OCPBUGS-105519: Fix flaky e2e tests missing warmupSPA - #16939
Conversation
The tests navigate directly to a deep URL without first warming up the SPA. The first navigation can land on the OAuth login page if the session has not been fully established in the browser context. Add a beforeEach hook calling warmupSPA to match the pattern used by all other test suites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-105519, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe changes update i18next extraction and node scheduling pluralization, build the dynamic plugin SDK directly, and warm up the SPA before tests in the web terminal and Knative CI suites. ChangesLocalization and node scheduling messages
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/jira refresh |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-105519, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-105519, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling tests matching the |
Same missing warmupSPA issue as web-terminal-config.spec.ts — tests navigate to deep URLs without first establishing the SPA session, causing intermittent failures stuck on the login page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@rhamilto: This pull request references Jira Issue OCPBUGS-105519, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling tests matching the |
|
/lgtm cancel eslint warnings |
|
/lgtm |
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling tests matching the |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-105519, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test analyze frontend |
21f23c1 to
e9a83db
Compare
|
try to force push to invalidate weird and broken build cache: /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling tests matching the |
|
/test analyze backend frontend images okd-scos-images |
71b4978
into
openshift:main
|
@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-105519 Jira Issue OCPBUGS-105519 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 5.0.0-0.nightly-2026-08-11-071938 |
Analysis / Root cause:
Multiple Playwright e2e test suites intermittently fail because the SPA session is not established before navigating to deep URLs. The page gets stuck on the OAuth login screen, and downstream locators (e.g.
actions-menu-button,fit-to-screen) time out because they never appear on the login page.Affected suites:
webterminal/web-terminal-config.spec.tsknative/serverless/knative-ci.spec.tsBoth suites navigate directly to deep URLs via
goTo()without first warming up the SPA. The Playwright browser context has saved storage state (cookies/tokens from the auth setup project), but the first navigation to a deep URL can land on the OAuth login page if the session has not been fully established in the browser context.Every other working test suite calls
warmupSPA(page)inbeforeEachto navigate to/first and confirm the sidebar is visible, which ensures the auth redirect completes and the SPA is ready before deep navigation.Solution description:
Added
test.beforeEachhooks that callwarmupSPA(page)in both test suites, matching the pattern used by all other test suites.Screenshots / screen recording:
Test setup:
Run the affected Playwright e2e test suites against a cluster.
Test cases:
web-terminal-config.spec.tstests pass consistentlyknative-ci.spec.tstests pass consistentlyBrowser conformance:
Additional info:
Jira: https://redhat.atlassian.net/browse/OCPBUGS-105519
Reviewers and assignees:
Summary by CodeRabbit
Bug Fixes
Tests