Skip to content

SPLAT-2588: fix hypershift topology variant to match Sippy classification #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 3 commits into from
Jun 23, 2026
+503 −3
Merged

SPLAT-2588: fix hypershift topology variant to match Sippy classification #2899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc00868
test(tools): add unit tests for featuregate-test-analyzer
mtulio Jun 22, 2026
f74255e
fix(tools): display hypershift in HTML/markdown reports for external …
mtulio Jun 22, 2026
5300823
fix(tools): use external topology for hypershift Sippy queries
mtulio Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions tools/codegen/cmd/featuregate-test-analyzer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,13 @@ func (o *FeatureGateTestAnalyzerOptions) Run(ctx context.Context) error {
return errors.Join(errs...)
}

func topologyDisplayName(topology string) string {
if topology == "external" {
return "hypershift"
}
return topology
}

func buildHTMLFeatureGateData(name string, testingResults map[JobVariant]*TestingResults, blockingErrors []error, release string) utils.HTMLFeatureGate {
jobVariantsSet := sets.KeySet(testingResults)
jobVariants := OrderedJobVariants(jobVariantsSet.UnsortedList())
Expand All @@ -269,7 +276,7 @@ func buildHTMLFeatureGateData(name string, testingResults map[JobVariant]*Testin
variants := make([]utils.HTMLVariantColumn, 0, len(jobVariants))
for i, jv := range jobVariants {
variants = append(variants, utils.HTMLVariantColumn{
Topology: jv.Topology,
Topology: topologyDisplayName(jv.Topology),
Cloud: jv.Cloud,
Architecture: jv.Architecture,
NetworkStack: jv.NetworkStack,
Expand Down Expand Up @@ -423,7 +430,7 @@ func writeTestingMarkDown(testingResults map[JobVariant]*TestingResults, md *uti
md.Exact("Test ")
for _, jobVariant := range jobVariants {
md.NextTableColumn()
columnHeader := fmt.Sprintf("%v <br/> %v <br/> %v ", jobVariant.Topology, jobVariant.Cloud, jobVariant.Architecture)
columnHeader := fmt.Sprintf("%v <br/> %v <br/> %v ", topologyDisplayName(jobVariant.Topology), jobVariant.Cloud, jobVariant.Architecture)
if jobVariant.NetworkStack != "" {
columnHeader = columnHeader + fmt.Sprintf("<br/> %v ", jobVariant.NetworkStack)
}
Expand Down Expand Up @@ -601,7 +608,7 @@ var (
{
Cloud: "aws",
Architecture: "amd64",
Topology: "hypershift",
Topology: "external",
},
// ibm and powervs?
}
Expand Down
Loading