SPLAT-2588: fix hypershift topology variant to match Sippy classification

[mtulio]

Fixes the topology variant mismatch between openshift/api's verify-feature-promotion tool and Sippy's variant classification for hypershift jobs.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@mtulio: This pull request references SPLAT-2588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Fixes the topology variant mismatch between openshift/api's verify-feature-promotion tool and Sippy's variant classification for hypershift jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @mtulio! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2b7bd9ba-a78f-4061-a989-3d3162461d4f

📥 Commits

Reviewing files that changed from the base of the PR and between 5346161 and 5300823.

📒 Files selected for processing (2)

• tools/codegen/cmd/featuregate-test-analyzer.go
• tools/codegen/cmd/featuregate-test-analyzer_test.go

---

📝 Walkthrough

Walkthrough

The requiredHypershiftJobVariants data structure changes its Topology field value from "hypershift" to "external", aligning the internal value with how sippy queries filter results. A new unexported helper topologyDisplayName maps "external" to "hypershift" for display, leaving other topology strings unchanged. Both the HTML feature-gate variant column headers and the Markdown testing-results table headers are updated to call this helper instead of using the raw topology string. The test file adds imports for fmt, sort, and strings, and introduces eleven new test functions covering the topology data value, Sippy query filtering, display-name mapping, platform detection, variant filtering, two-node feature-gate matching, test result lookup, variant ordering, JobTiers validation, and HTML feature-gate data generation.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: fixing hypershift topology variant classification to match Sippy's system.
Description check	✅ Passed	The description is directly related to the changeset, explaining the topology variant mismatch fix for hypershift jobs in the verify-feature-promotion tool.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names in the PR use stable, deterministic values. Two tests use fmt.Sprintf to format static test data (variant names, topologies, cloud providers), but values are hardcoded and repeat con...
Test Structure And Quality	✅ Passed	The custom check targets Ginkgo test code, but this PR contains Go standard testing package tests, not Ginkgo tests. The check is not applicable.
Microshift Test Compatibility	✅ Passed	This PR does not add any Ginkgo e2e tests. It only modifies a code generation tool and adds standard Go unit tests. The custom check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. The new tests are standard Go unit tests for a code generation tool, using the testing.T framework, not Ginkgo patterns.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only featuregate-test-analyzer tool that generates test reports; no deployment manifests, operator code, or scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	All fmt.Printf statements are in regular command execution functions (listTestResultFor, listTestResultForVariant), not process-level code like main/init, so they don't violate OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds only standard Go unit tests in tools/codegen (not Ginkgo e2e tests). No e2e test patterns (Describe, It, Context, When, By) or connectivity/IPv4 assumptions found.
No-Weak-Crypto	✅ Passed	No weak cryptographic algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or non-constant-time secret comparisons found in the modified files.
Container-Privileges	✅ Passed	The PR modifies Go source files (featuregate-test-analyzer.go/test.go) and does not contain any container or Kubernetes manifests with privileged configurations.
No-Sensitive-Data-In-Logs	✅ Passed	Logging contains only non-sensitive operational data: feature gate names, cluster profiles, test results, release versions, and infrastructure metadata. No passwords, tokens, API keys, PII, or othe...

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

/lgtm
/verified by @mtulio

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by @mtulio.

Details

In response to this:

/lgtm
/verified by @mtulio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the master branch

Use /test ? to see all available tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment