Skip to content

HYPERFLEET-1614 - ci: prefetch gomod dependencies for Hermeto attribution - #261

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1614-hermeto-prefetch
Sep 4, 2026
Merged

HYPERFLEET-1614 - ci: prefetch gomod dependencies for Hermeto attribution#261
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1614-hermeto-prefetch

Conversation

@ciaranRoche

@ciaranRoche ciaranRoche commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • configure push and tag pipelines to prefetch Go modules
  • ensure generated SBOM packages carry Hermeto attribution before enforcement

HYPERFLEET-1614

@openshift-ci
openshift-ci Bot requested review from Ruclo and pnguyen44 September 4, 2026 09:53
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d936a635-0001-491a-9b21-1aacfb36bb7e

📥 Commits

Reviewing files that changed from the base of the PR and between 26a848b and 1e71fec.

📒 Files selected for processing (2)
  • .tekton/hyperfleet-sentinel-push.yaml
  • .tekton/hyperfleet-sentinel-tag.yaml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual) → reviewed against open PR #366 HYPERFLEET-1614-hermeto-prefetch instead of the default branch
  • openshift-hyperfleet/hyperfleet-sentinel (manual)
  • openshift-hyperfleet/hyperfleet-adapter (manual) → reviewed against open PR #293 HYPERFLEET-1614-hermeto-prefetch instead of the default branch
  • openshift-hyperfleet/hyperfleet-broker (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Enhancements
    • Enabled Go module dependency prefetching for push-triggered pipeline executions.
    • Enabled Go module dependency prefetching for tag-triggered pipeline executions.

Walkthrough

The push-triggered and tag-triggered Tekton PipelineRun definitions now set prefetch-input to {"type": "gomod"}. This enables Go module dependency prefetching for both pipeline execution paths.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1e71f

Push and tag pipelines now consistently prefetch Go module dependencies. The configuration is ready to merge.

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed PASS. The pull request adds only two Tekton parameter assignments in each YAML file: prefetch-input with {"type": "gomod"}. The added lines contain no slog, log, logr, zap, or fmt.Print*
No Hardcoded Secrets ✅ Passed PASS — The pull request adds only prefetch-input with the literal {"type": "gomod"} to two Tekton configuration files. The added value is not an API key, token, password, private key, credential-b…
No Weak Cryptography ✅ Passed PASS. The pull request adds only prefetch-input values of {"type": "gomod"} to two Tekton PipelineRuns. The exact diff adds no crypto/md5, crypto/des, crypto/rc4, SHA-1, ECB, custom cryptogr…
No Injection Vectors ✅ Passed PASS — The pull request adds only the hardcoded prefetch-input value {"type": "gomod"} to two Tekton YAML files. The changed files contain no SQL construction, fmt.Sprintf query, exec.Command/…
No Privileged Containers ✅ Passed PASS. The pull request adds only prefetch-input with {"type": "gomod"} to two tekton.dev/v1 PipelineRun CI manifests. It does not add privileged: true, host namespace settings, SYS_ADMIN, …
No Pii Or Sensitive Data In Logs ✅ Passed PASS. The commit changes only two Tekton YAML files. Each added line sets prefetch-input to {"type": "gomod"}. The added lines introduce no slog, logr, zap, log, or fmt.Print* logging st…
Description check ✅ Passed The description directly matches the changes. It identifies Go module prefetching for push and tag pipelines and Hermeto attribution for generated SBOM packages.
Title check ✅ Passed The title clearly identifies the CI change: prefetching Go module dependencies for Hermeto attribution. It is concise and related to the main changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1614-hermeto-prefetch
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch HYPERFLEET-1614-hermeto-prefetch

Comment @coderabbitai help to get the list of available commands.

@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 0 — risk/low

Signal Detail Points
PR size 4 lines +0
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

@ma-hill

ma-hill commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ma-hill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Sep 4, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 52eef7c into main Sep 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants