Skip to content

HYPERFLEET-1614 - ci: prefetch gomod dependencies for Hermeto attribution - #293

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1614-hermeto-prefetch
Sep 4, 2026
Merged

HYPERFLEET-1614 - ci: prefetch gomod dependencies for Hermeto attribution#293
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1614-hermeto-prefetch

Conversation

@ciaranRoche

@ciaranRoche ciaranRoche commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • configure push and tag pipelines to prefetch Go modules
  • ensure generated SBOM packages carry Hermeto attribution before enforcement

HYPERFLEET-1614

@openshift-ci
openshift-ci Bot requested review from Mischulee and ma-hill September 4, 2026 09:53
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 692da7d3-5cfa-4998-a9aa-3f1a89213ddd

📥 Commits

Reviewing files that changed from the base of the PR and between 6b5adad and 1a75f17.

📒 Files selected for processing (2)
  • .tekton/hyperfleet-adapter-push.yaml
  • .tekton/hyperfleet-adapter-tag.yaml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual) → reviewed against open PR #366 HYPERFLEET-1614-hermeto-prefetch instead of the default branch
  • openshift-hyperfleet/hyperfleet-sentinel (manual) → reviewed against open PR #261 HYPERFLEET-1614-hermeto-prefetch instead of the default branch
  • openshift-hyperfleet/hyperfleet-adapter (manual)
  • openshift-hyperfleet/hyperfleet-broker (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated automated build and tag pipelines to prefetch Go module dependencies.
    • This improves dependency availability during pipeline execution and can help make builds more efficient and reliable.

Walkthrough

The push-triggered and tag-triggered Tekton PipelineRuns now set prefetch-input to {"type": "gomod"}. This identifies Go module dependencies for prefetching in both pipeline paths.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1a75f

Push and tag pipelines now request Go module prefetching for SBOM attribution. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI change: prefetching Go module dependencies for Hermeto attribution.
Description check ✅ Passed The description directly explains the push and tag pipeline changes and the Hermeto attribution objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed PASS. Commit 1a75f17 changes only two Tekton YAML files and adds prefetch-input with the non-secret value {"type": "gomod"}. The added lines contain no slog, log, logr, zap, or `fmt.Print*…
No Hardcoded Secrets ✅ Passed The pull request adds only prefetch-input with the literal {"type": "gomod"} in two Tekton YAML files. This value is not an API key, token, password, private key, credential-bearing URL, or base64…
No Weak Cryptography ✅ Passed PASS. The commit changes only two Tekton YAML files and adds prefetch-input with {"type": "gomod"}. The added lines contain no banned primitive, cryptographic comparison, or custom cryptographic i…
No Injection Vectors ✅ Passed PASS. The pull request adds only the hardcoded JSON value {"type": "gomod"} to prefetch-input in two Tekton PipelineRuns. The value is trusted constant data. The diff adds no SQL construction, `fm…
No Privileged Containers ✅ Passed PASS. The pull request adds only prefetch-input: '{"type": "gomod"}' to two Tekton PipelineRun CI manifests. The added lines do not set privileged, hostPID, hostNetwork, hostIPC, `SYS_ADMI…
No Pii Or Sensitive Data In Logs ✅ Passed No logging statement changed. The pull request only adds prefetch-input with {"type": "gomod"} to two Tekton PipelineRuns. The exact diff contains no slog, logr, zap, log, or fmt.Print*
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1614-hermeto-prefetch
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch HYPERFLEET-1614-hermeto-prefetch

Comment @coderabbitai help to get the list of available commands.

@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 0 — risk/low

Signal Detail Points
PR size 4 lines +0
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

@ma-hill

ma-hill commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ma-hill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Sep 4, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit f6896c1 into main Sep 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants