fix(sandbox): enforce Windows mypy compatibility - #4499
Merged
Conversation
Co-authored-by: rome-xi <rome-xi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes Windows-targeted mypy errors in the sandbox implementation and adds a dedicated
mypy-win32CI job that runs in parallel with the existing typecheck job.It preserves the source corrections from #4482, removes the runtime-only regression tests that pass against the unfixed base, and checks the complete
srctree withmypy --platform win32. The new job uses an isolated mypy cache key so Windows-targeted results cannot collide with the existing Linux cache.Resolves #4477