fix(sandbox): make typecheck pass on Windows - #4482
Closed
rome-xi wants to merge 1 commit into
Closed
Conversation
Signed-off-by: rome-xi <rome-xi@users.noreply.github.com>
4 tasks
Member
|
Thanks for sending this. #4499 resolves the issue and its commit includes you as a co-author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make typecheckreports three mypy errors on Windows and none on Linux. On win32, typeshed typestempfile.TemporaryFile()as_TemporaryFileWrapper[bytes], which is not anIOBasesubclass, sostrip_tar_member_prefixand Docker hydrate fail. Windows mypy also treatsprocessas unbound after the PTYtry/except/elseinunix_local.Cast the TemporaryFile objects to
io.IOBaseat those two sites, and create the PTY session entry inside theelsebranch whereprocessis defined. No public types are widened.Test plan
uv run mypy --platform win32 --follow-imports=silenton the three affected modules--platform linuxstays cleantests/sandbox/test_windows_tempfile_iobase.pycovers the seekable-stream contractIssue number
Fixes #4477