Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/agents/function_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def _detect_docstring_style(doc: str) -> DocstringStyle:
def _suppress_griffe_logging():
# Suppresses warnings about missing annotations for params
logger = logging.getLogger("griffe")
previous_level = logger.getEffectiveLevel()
previous_level = logger.level
logger.setLevel(logging.ERROR)
try:
yield
Expand Down
26 changes: 26 additions & 0 deletions tests/test_function_schema_logger_restore.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
from __future__ import annotations

import logging

from agents.function_schema import _suppress_griffe_logging


def test_suppress_griffe_logging_restores_configured_notset_level() -> None:
logger = logging.getLogger("griffe")
root_logger = logging.getLogger()
previous_logger_level = logger.level
previous_root_level = root_logger.level

try:
logger.setLevel(logging.NOTSET)
root_logger.setLevel(logging.WARNING)
assert logger.getEffectiveLevel() == logging.WARNING

with _suppress_griffe_logging():
assert logger.level == logging.ERROR

assert logger.level == logging.NOTSET
assert logger.getEffectiveLevel() == logging.WARNING
finally:
logger.setLevel(previous_logger_level)
root_logger.setLevel(previous_root_level)
Loading