Skip to content

fix(schema): preserve Griffe logger inheritance - #4494

Merged
seratch merged 2 commits into
openai:mainfrom
sylvesterkaczmarek:fix/griffe-logger-level-restore
Aug 17, 2026
Merged

fix(schema): preserve Griffe logger inheritance#4494
seratch merged 2 commits into
openai:mainfrom
sylvesterkaczmarek:fix/griffe-logger-level-restore

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor

Summary

  • restore the Griffe logger's configured level after docstring parsing
  • preserve NOTSET inheritance instead of replacing it with the inherited effective level
  • keep warning suppression during parsing unchanged

_suppress_griffe_logging() captured logger.getEffectiveLevel(). When the griffe logger inherited its level via NOTSET, leaving the context permanently replaced NOTSET with the inherited numeric level and changed future logging configuration.

Test plan

  • added focused regression coverage in tests/test_function_schema_logger_restore.py
  • GitHub Actions

Issue number

N/A

@sylvesterkaczmarek
sylvesterkaczmarek marked this pull request as ready for review August 17, 2026 20:42
@seratch
seratch merged commit 057ab10 into openai:main Aug 17, 2026
15 checks passed
@seratch seratch added this to the 0.21.x milestone Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants