fix(deep): fence stale publication and preserve replay - #916
mldangelo-oai wants to merge 5 commits into
Conversation
|
@codex review Please review the current head, |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review the current head, |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e623ac2ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the current head, |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a5983f7aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
A replaced Deep coordinator can publish an obsolete aggregate over a newer result. Check the current coordinator generation and selected reducer under the completion lock, while preserving partial checkpoints and replay after an output-write failure.
Changes
Testing
Validation for
4a5983f7aac613131d2ee8eec12a6b5170857136:build:ci, plugin source compatibility and its Node tests. SDK/MCP types, formatting and plugin build passed.Three fresh native source reviews and independent verification found no actionable issues. CI passed on this head. Hosted review reported a partial-publication race; independent real-store tests rejected the claimed public-tool path in both request orderings. The source and scope-limited disposition are recorded in the review thread. Reviewer runtime limitations are separate from the successful qualification above.
Risk and rollout
Generation-one drafts retain their supported path. Adopted coordinators must provide their current generation and selected result for final publication. There is no schema migration, new command or new retry layer. Recovery after a lost host response is a separate dependent change; this PR covers publication fencing and workbench replay. Unclaimed legacy generation-one drafts and direct lower-level writes without the public digest contract remain separate compatibility paths; the hosted-race disposition does not claim to fence every trusted local invocation.
Public disclosure review