fix(deep): recover accepted publication response loss - #938
mldangelo-oai wants to merge 5 commits into
Conversation
|
@codex review Please review exact head |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9aae3378e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Recover a Deep publication whose canonical writes succeeded but whose child-process response was lost. The host replays the exact acknowledged operation once through the existing publication checks. Failure to write the optional acknowledgment no longer turns a successfully delivered publication into an error.
Changes
Testing
At
774b4d5690af94fcaefd155c869e5e600ca8f8a1:Broader suites ran at
91515fad38556d651d8387e6ecc13edde66062a6, before the test-only delete-on-close emulator correction; their runtime inputs are unchanged: Python 1,126 passed, 8 skipped, 109 subtests passed, 1 pre-existing fallback-test failure; MCP 72 passed; relevant SDK checks 98 passed. The fallback failure reproduces on the unchanged prerequisite. Final affected checks above include the corrected emulator.Native platform CI passed at this exact head. The explicit Windows storage/path-error fault cases used Linux emulation; generic platform CI does not establish every native Win32 error-injection path. Earlier-head platform results are not inherited.
Risk and rollout
Stacked on #916, which must land first. No public command, flag, schema or workflow activation changes. Replay requires the exact acknowledgment and re-enters publication validation; process exit alone is not acceptance. An absent acknowledgment still prevents replay after response loss. Historical failed scans whose terminal reason was already lost are not reconstructed.
Public disclosure review