Repository navigation
Conversation
Signed-off-by: Aadhish <aadhi5h.20.09.2006@gmail.com>
aadhi5h
force-pushed
the
fix/status-overview-pending-phases
branch
from
October 2, 2026 06:38
a35876f to
937c1a1
Compare
mxgrey
self-requested a review
October 6, 2026 01:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Fixes #147.
rmf_task_sequence::Task::Active::status_overview()could report a task asCompletedwhen the current phase had completed but subsequent phases were still pending.This could cause the task status to indicate completion even though the task still had phases that had not been activated or completed.
Fix applied
Updated
Task::Active::status_overview()to check for pending phases when an active phase exists.If there are pending phases, the task now reports
Event::Status::Underwayinstead of returning the status of the active phase's final event.Added a regression test that checks the task status during the phase-finished callback, when the completed phase has been recorded but the next pending phase has not yet been activated.
The regression test fails with the original implementation and passes with the fix.
GenAI Use
Generated-by: Google Gemini