Skip to content

fix(spec): os migrate meta --stored lists a stored dashboard whose global filter reuses the reserved dateRange key - #29586

Closed
objectstack-fleet[bot] wants to merge 2 commits into
mainfrom
claude/project-thread-uezs7d
Closed

objectstack-fleet[bot] wants to merge 2 commits into
mainfrom
claude/project-thread-uezs7d

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Warren · project thread
Fixes #29541

Clause-②: no
Metadata-protocol: none

维护者速读

What changes

  • Stored listing. REFUSED_STORED_SHAPES gains dashboardReservedDateRangeGlobalFilter (id ui-dashboard-global-filter-reserved-date-range-refused, the spec(dashboard): a globalFilters entry named dateRange parses and silently replaces the built-in date range's binding #29213 D3 entry of step 18), registered right after dashboardDuplicateGlobalFilterName. It walks stack.dashboards[] and calls reservedDateRangeGlobalFilters(dashboard.dateRange, dashboard.globalFilters) from ui/duplicate-global-filter-names.ts, the predicate DashboardSchema's refinement reads; no logic is copied. One TODO per entry, at dashboards[i].globalFilters[j].name (or .field when the entry has no name), which is the site the parse refuses. from carries the reserved key and the index only. The reason leads with the fate (no lossless rewrite, loads with _diagnostics.valid: false, next save refused 422) and ends with the predicate's own message.
  • Upgrade guide entries. acceptanceCriteria of 18.ui-dashboard-global-filter-reserved-date-range-refused.ts and of 18.ui-dashboard-global-filter-duplicate-name-refused.ts (dashboards: two globalFilters with the same name are accepted; the board draws one control and its value filters the other filter's field #29023) each gain one sentence: os migrate meta --stored lists each such stored dashboard under the entry's id, at the site the parse refuses.
  • Docblock. The refused-shapes.ts header's list of borrowed predicates names reservedDateRangeGlobalFilters.
  • Changeset. .changeset/29541-reserved-date-range-stored-detector.md, @objectstack/spec patch.

Why

The refusal's D3 entry already promised that a stored row with the pair loads as invalid and is refused on its next save, but the stored preview read such a row as already on protocol. An operator previewing the upgrade saw nothing.

Tests

refused-shapes.test.ts gains five cases under #29541, and the roster pin names the new id:

  • the card shape (a declared dateRange beside an entry named dateRange): one TODO at dashboards[0].globalFilters[0].name with the reserved word, the built-in date range and the predicate's message; the row is not rewritten, and the parse still refuses the same site;
  • an entry with no name and field: 'dateRange': listed once at .field, as the parse locates it;
  • two entries both named dateRange: listed under each refusal (one duplicate-key TODO and two reserved-key TODOs), exactly the three custom issues the parse raises;
  • CONTROL: with no dateRange declared, an entry keyed dateRange (by name or by field) is not listed and the parse accepts it;
  • CONTROL: beside a declared dateRange, a named entry whose field is dateRange is not listed and parses.

Ablation (fix committed first; scripts/ablation-replace.mjs --delete on the registry line dashboardReservedDateRangeGlobalFilter,): Tests 4 failed | 84 passed (88). The roster pin and the three listing cases went red, both controls stayed green. Restored: blob after restore equals HEAD, git diff HEAD empty. The spec suite imports ./refused-shapes.js from source, so no dist was involved.

Acceptance notes

Verification

Head 9e7c4c35: one merge of origin/main at dbca3ef0. Every reading below was taken on that head.

Package readings
  • pnpm --filter @objectstack/spec build: exit 0.
  • pnpm --filter @objectstack/spec check:generated: all 14 generated artifacts up to date, exit 0.
  • pnpm --filter @objectstack/spec test: Test Files 799 passed (799), Tests 23667 passed | 1 todo (23668), exit 0.
  • pnpm --filter @objectstack/spec typecheck: exit 0.
  • pnpm exec eslint --no-inline-config over the four changed source and test files: exit 0. The repo-wide pnpm lint is CI's.
Derived gates
  • node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 81 families from 5 paths (144 changed lines). Each was run after the last commit, with its exit code recorded. --ran answered: 81 derived, 81 run, 0 NOT-MEASURED, 0 UNRUN (exit 0).
  • pnpm check:dual-build-cjs-loads first answered exit 3 (PREREQUISITE NOT MET, packages with no dist/). After turbo run build --filter='./packages/**' (78 tasks, all cache hits) it answered exit 0: 115 entry points across 70 packages.
  • node scripts/check-plugin-teardown-shape.mjs --self-test: the pinned control commit 621a4876 was fetched first; exit 0.
  • CI families (Lint & Repo Gates, TypeScript Type Check, Test Core, Build Core, the UI jobs) are read from this PR's check-runs, not re-run here. Dogfood is not owed: there is no ! in the title and no (narrowing) arm.

Human Minimum

  • 1. Schemas start as Zod; packages/spec holds no runtime logic.
  • 2. Every name I added uses the casing for its kind.
  • 3. No formatter ran; pnpm lint passes.
  • 4. One issue, one branch off an up-to-date main, one pull request.
  • 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset.
  • 6. packages/spec touched: its generated artifacts are regenerated and committed.
  • 7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
  • 8. Title, body and comments are in English.
  • The Before Submitting list in CONTRIBUTING.md is done.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JQwxbXBJMBnWyspsxBN7j8


Generated by Claude Code

…obal filter reuses the reserved dateRange key

REFUSED_STORED_SHAPES gains dashboardReservedDateRangeGlobalFilter, built on
reservedDateRangeGlobalFilters (the dashboard refinement's own predicate), and
both dashboard globalFilters D3 entries say the stored pass lists such a row.

Claude-Session: https://claude.ai/code/session_01JQwxbXBJMBnWyspsxBN7j8
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added size/m documentation Improvements or additions to documentation tests tooling labels Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

4 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to list — not a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • 2 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 60 of 216 client-bound route-ledger rows — the other 156 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 156: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 101 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 168 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json b16ee8ba069d00bc00d01295869c1036fc9ea2e2 → packageMentionDocs.

Which tree this was computed on

This run read content/docs from 1c99e0d779b7ad01b7f08a235456850ff051ed4e — the merge of head 9e7c4c35d569f3bc5dafb33d18b9c44574a2644a into base b16ee8ba069d00bc00d01295869c1036fc9ea2e2, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 1c99e0d779b7ad01b7f08a235456850ff051ed4e && git checkout 1c99e0d779b7ad01b7f08a235456850ff051ed4e
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin b16ee8ba069d00bc00d01295869c1036fc9ea2e2 9e7c4c35d569f3bc5dafb33d18b9c44574a2644a && git checkout -B drift-repro b16ee8ba069d00bc00d01295869c1036fc9ea2e2 && git merge --no-ff 9e7c4c35d569f3bc5dafb33d18b9c44574a2644a

node scripts/docs-audit/affected-docs.mjs --json b16ee8ba069d00bc00d01295869c1036fc9ea2e2

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:spec#5 · os-warren · session_01JQwxbWR3K3h7i1ytwycVg1

Contract-review-hold: session_01JQwxbWR3K3h7i1ytwycVg1 · head 9e7c4c3 · serial: conversions/refused-shapes.ts is also edited by draft PR #29589 (#29554, domain:spec#3), which lands first, so this head is not the landing head · until #29589 merges and this branch merges origin/main

The lane runs the at-tier review on the post-merge head.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:spec#2 · os-support-ai · session_01WGufzhJG3tKnksHVa1krBz

Superseded by #29720: the same commits resumed on the card thread branch claude/project-thread-une4f5 (claim on #29541), merged with origin/main after #29589 landed, both detectors kept. Closing this draft so #29541 has one open closing PR. Contract-review-hold 6588352743 stays here as the history of head 9e7c4c35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/m tests tooling

Projects

None yet

1 participant