Repository navigation
chore(ui): retire the zero-consumer root and config orphans (paseo, typedoc, lazy-test, console dead devDeps) - #28298
Merged
Conversation
Delete ui/paseo.json, ui/typedoc.json (with the typedoc and typedoc-plugin-markdown devDependencies and the docs:api script) and ui/lazy-test.mjs (with its exemption row in check-lint-rule-coverage). Drop the console's @dnd-kit/* and autoprefixer devDependencies: no console source, config or test imports them, and @dnd-kit still reaches the console bundle through the workspace packages that declare it, so the vendor-dndkit chunk rule in vite.config.ts stays. Claude-Session: https://claude.ai/code/session_01L6bhgUoyJkVmoaxp9BeAHY Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
domain:ui#4 · os-sales · session_01L6bhgWqjXeTcS3jtug46Dv 维护者速读
席位意见:ACCEPT。纯删除,零消费者实测可复核。保留 席位核对 — ACCEPT · domain:ui#4 · Head-sha
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2026
Contributor
Author
|
domain:ui#4 · os-sales · session_01L6bhgWqjXeTcS3jtug46Dv Queue kick-out triage · 2026-10-31T04:43Z · head
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sales · project thread
Part of #25921
Clause-②: no
Metadata-protocol: none
维护者速读
ui/下三个没人用的根配置文件(paseo.json、typedoc.json、lazy-test.mjs),连带typedoc/typedoc-plugin-markdown两个 devDep、docs:api脚本和 lint 覆盖账本里lazy-test.mjs那一行;再删 console 的四个死 devDep(@dnd-kit/core|sortable|utilities、autoprefixer),lockfile 随之重生成(纯删 256 行)。origin/main上重测都是零消费者,留着只会误导(paseo.json还在教pnpm i,违背 frozen-lockfile 规则)。vendor-dndkit分块照常产出(dnd-kit 经 app-shell 等包传入)。回滚 = revert 本 PR。ui/apps/console/package.json(删的四个 devDep)、ui/scripts/check-lint-rule-coverage.mjs(删一行豁免)、pnpm-lock.yaml。pnpm install --frozen-lockfile && git grep -n -E "typedoc|paseo|lazy-test" -- ui—— 安装成功,grep 零命中。What changes
ui/paseo.json,ui/typedoc.json,ui/lazy-test.mjs.ui/package.json: dropped thedocs:apiscript and thetypedocandtypedoc-plugin-markdowndevDependencies.typedoc-plugin-markdownis named only bytypedoc.json'spluginlist, so it goes with the typedoc item.ui/scripts/check-lint-rule-coverage.mjs: dropped thelazy-test.mjsrow from the vacuous-group list (its only reference).ui/apps/console/package.json: dropped the@dnd-kit/core,@dnd-kit/sortable,@dnd-kit/utilitiesandautoprefixerdevDependencies.pnpm-lock.yaml: regenerated withpnpm install; the diff is deletions only (the two importers' entries plus typedoc's private closure: typedoc, typedoc-plugin-markdown,@gerrit0/mini-shiki, four@shikijs/*, lunr, markdown-it, linkify-it, mdurl, punycode.js, uc.micro, entities 4).Why
Zero-consumer measurement on
origin/main69ce01d7(the claim's base),git grepover the whole tree, lockfile and CHANGELOGs excluded:paseo.jsonscripts/check-ci-filter-parity.mjs(not a reader)typedoc/typedoc.json/docs:apiui/package.jsonitself, plus a historical comment inpnpm-workspace.yaml(see Acceptance notes)lazy-test.mjscheck-lint-rule-coverage.mjsautoprefixerui/apps/console; itspostcss.config.jsloads only@tailwindcss/postcss@dnd-kit/*Positive control for the same grep:
@dnd-kithits 45 files onorigin/main, 39 of them underui/packages/(app-shell 11, plugin-kanban 17, layout 3, plugin-dashboard 3, plugin-view 3, components 1, react 1).app-shell,layout,plugin-kanbanandplugin-dashboardeach declare all three@dnd-kitpackages themselves.Kept: the
vendor-dndkitentry inui/apps/console/vite.config.ts. It is a real consumer of the bundle, not of the console's declaration:@dnd-kitstill reaches the console build through the workspace packages above. Measured: the console build on this branch still emitsassets/vendor-dndkit-*.js. Sovite.config.tsis not touched.Excluded, left on the card: the two playwright import-harness configs (the docs/qa checklist's knownGaps names them), the providers/upload fold, the two remaining reset helpers (
resetActionKeyWarningssits behind open PR #28188), the msw text inskills/**(governed), i18n keys, and the per-package barrel batches.No changeset (
skip-changeset): nothing a released package ships changes.ui/package.jsonis the private workspace root.@object-ui/consoleonly loses devDependencies, which an installer never reads, and its builtdist/keeps the same@dnd-kitresolution throughapp-shell.Acceptance notes
pnpm-workspace.yamlkeeps the override'markdown-it@>=14.0.0 <14.3.3': '^14.3.3'and its comment ("pulled 14.3.0 through typedoc and @vscode/vsce"). After this PRmarkdown-itis gone from the lockfile entirely, so the override matches nothing. That file is outside this claim's surface, so it is left as it is: dropping the override and its comment is a one-line follow-up for the seat to route.check:override-consistencyexits 0 on this head.claude/project-thread-u9x8uuis the platform-assigned card-thread branch (the claim records it), notclaude/issue-N-slug.Verification
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 36 commands on8fe61662; all 36 ran, and--ranreports36 derived, 36 run, 0 NOT-MEASURED, 0 UNRUN. On the first pass, three were prerequisite readings, not verdicts on the diff:vitest run scripts/exit 1 (two suites could not resolve unbuilt@objectstack/client/@objectstack/spec),check:dts-closureexit 1 (missing.d.ts), andcheck:dual-build-cjs-loadsexit 3. After building (console closure 71/71,./packages/**76/76), all three exit 0.vitest run scripts/then gave 169 files passed, 2 skipped; 4901 tests passed. After mergingorigin/main(4 commits, none touching these files), the re-derived list is identical.node scripts/check-sdui-manifest.mjsexit 0;eslint scripts/check-lint-rule-coverage.mjs(inui/) exit 0;node scripts/check-lint-rule-coverage.mjsexit 0;pnpm install --frozen-lockfileexit 0 on the regenerated lockfile.turbo run build --filter=@object-ui/console...71/71,os-verify-lockVERDICT command-exit 0;ui/apps/console/dist/assets/vendor-dndkit-*.jsemitted.git merge-tree --write-treeagainst every open PR: clean (exit 0) for all 19. Only the mailbox PRs pm:mailbox — os-sales #27357, pm:mailbox — os-justin #27309 and pm:mailbox — marchtian #27523 and the Version Packages PR chore: version packages #26517 touch any of these files, and each merges clean.Generated by Claude Code
🤖 Generated with Claude Code
https://claude.ai/code/session_01L6bhgUoyJkVmoaxp9BeAHY