Repository navigation
test(app-shell): give the new package-door matrix doubles the draft-overlaid read - #27103
Merged
Merged
Conversation
…overlaid read Both new package-door tests landed beside #26840, whose load now reads the package's objects through MetadataClient.withPreviewDrafts; their fake clients lacked it, which turned main red on Test UI. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Oct 28, 2026
Contributor
Author
席位核对ACCEPT · seat 席位意见:修 main 红。#27064 和 #27080 在队列里与 #27010 交叉合入,两个测试的假 client 缺
Generated by Claude Code |
This was referenced Oct 28, 2026
Closed
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Warren · project thread
Fixes #27095
Clause-②: no
Metadata-protocol: none
维护者速读
description,packageId) — the save starts from the published body and copies back only editor-managed keys #26837)的假客户端补上withPreviewDrafts,只改测试,不改产品代码。PermissionMatrixEditor.objectGrantInherited-27010.test.tsx与PermissionMatrixEditor.packageDoorDraftBase-26837.test.tsx的makeClient。pnpm --dir ui exec vitest run packages/app-shell/src/views/metadata-admin/PermissionMatrixEditor.objectGrantInherited-27010 packages/app-shell/src/views/metadata-admin/PermissionMatrixEditor.packageDoorDraftBase-26837,预期全绿。What changes
withPreviewDrafts() { return this; }added to the fake client of the two package-door matrix tests that merged beside #26840 (PR #27064): #27010'sobjectGrantInherited-27010and #26837'spackageDoorDraftBase-26837. Same addition as the other matrix doubles. No product code changes.Why
Main went red on Test UI (shards 11 and 12) after queue merges crossed: #27064 made the package door read objects through
MetadataClient.withPreviewDrafts(true), and these two new tests' fakes did not have that method.Tests
main): Test Files 2 failed, Tests 4 failed.draftObjects-26840: Test Files 3 passed, Tests 28 passed.76e90df6with the Studio Access pillar: the permission matrix draws some object grants differently from what the runtime enforces (detail withheld pending maintainer) #27010 fix (714 tests). The other 36 files withoutwithPreviewDraftsnever mount the matrix under apackageId, so they never call it.Verification
Derived gates are in the os-dev report on #27095.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JQwxbYLTHkXTxBf89Sud8r
Generated by Claude Code