Skip to content

test(app-shell): give the new package-door matrix doubles the draft-overlaid read - #27103

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-a4f92k
Oct 28, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-a4f92k

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Warren · project thread
Fixes #27095

Clause-②: no
Metadata-protocol: none

维护者速读

What changes

withPreviewDrafts() { return this; } added to the fake client of the two package-door matrix tests that merged beside #26840 (PR #27064): #27010's objectGrantInherited-27010 and #26837's packageDoorDraftBase-26837. Same addition as the other matrix doubles. No product code changes.

Why

Main went red on Test UI (shards 11 and 12) after queue merges crossed: #27064 made the package door read objects through MetadataClient.withPreviewDrafts(true), and these two new tests' fakes did not have that method.

Tests

Verification

Derived gates are in the os-dev report on #27095.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JQwxbYLTHkXTxBf89Sud8r


Generated by Claude Code

…overlaid read

Both new package-door tests landed beside #26840, whose load now reads the
package's objects through MetadataClient.withPreviewDrafts; their fake
clients lacked it, which turned main red on Test UI.

Co-Authored-By: Claude <noreply@anthropic.com>
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对

ACCEPT · seat domain:ui#1 · session_01JQwxbZeBv2y91towxasSUT · head 039a8750 · 2026-10-28T06:04Z

席位意见:修 main 红。#27064 和 #27080 在队列里与 #27010 交叉合入,两个测试的假 client 缺 withPreviewDrafts;本 PR 只给这两个假 client 各补一行,产品代码不动。

  1. Shape: Fixes #27095; 2 test files, +4/−0. Each fake gains withPreviewDrafts() { return this; } with a one-line citation. Labelled skip-changeset.
  2. Premise measured: on main 76e90df6 the Studio Access pillar: the permission matrix draws some object grants differently from what the runtime enforces (detail withheld pending maintainer) #27010 file's package-door case failed at L103 (check run 122646737436), and on dc87dfb5 all 3 tests of the Studio Access: saving a permission set drops draft values written by another door (description, packageId) — the save starts from the published body and copies back only editor-managed keys #26837 file failed on shard 12 (run 40637892600). Both fakes lacked the method that the package-door load now calls. Returning this keeps each fake's list / get answering as before, which is what those tests assert against. Dev: red leg 4 failing on main, green leg 28/28 with draftObjects-26840; sweep of 74 matrix-mounting files (714 tests) green. The other 36 fakes without the method never mount the matrix under a packageId.
  3. Gates / check-runs: PR check-runs on 039a8750: 43 success, 16 skipped, 0 failure; mergeable_state clean. The dev's derived gates and card report follow; the seat lands now because main is red.
  4. Accepted deviations: the branch was recreated from origin/main with a plain push (the old remote branch had been deleted after fix(app-shell): list a package's draft objects in the Access matrix, badged as drafts #27064 merged), so no force was used.
  5. Out of scope: the merge queue merged fix(app-shell): list a package's draft objects in the Access matrix, badged as drafts #27064 and fix(app-shell): a package-door permission save keeps the pending draft's values #27080 although their queue builds failed Test UI; reported to the coordinator for the ci lane. Skills-docs: none — test doubles only.
  6. Landing: not Tier H; the seat readies and arms auto-merge.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 28, 2026 06:05
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 28, 2026 06:05
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 84e1370 Oct 28, 2026
60 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/project-thread-a4f92k branch October 28, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main red: the #27010 permission-matrix test fake has no withPreviewDrafts after #27064

2 participants