Skip to content

docs(agents): drop the director's five-row batch from Prime Directive 14; pin two skill line ceilings - #26765

Merged
os-zhuang merged 1 commit into
mainfrom
claude/project-thread-qilewq
Oct 27, 2026
Merged

os-zhuang merged 1 commit into
mainfrom
claude/project-thread-qilewq

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Steve · project thread
Fixes #26697
Clause-②: no
Metadata-protocol: none

维护者速读

  • 改了什么:AGENTS.md 第 14 条删掉「总监席把批准请求打成一批、每批最多五行」这一分句;两条技能行数上限按实测下调(49、87)。
  • 为什么改:你说过「所以总监席你呈给我完全没必要啊」,技能文件已按此改完,但 AGENTS.md 优先级更高、还写着相反规则。
  • 风险与回滚:只删一个分句,批准与落地规则本身不变;回滚即 revert 本 PR。
  • 先看:AGENTS.md 第 279–280 行;scripts/pm/check-skill-line-ratchet.mjs 两行数字。
  • 两分钟验证:git grep -n "batch of at most five" AGENTS.md .claude 应无输出;pnpm check:pm-skill-ratchet 应全绿。
  • 需要你做的:批准本 PR

What changes

The pm-dispatch skill already dropped the batch rule (#26693, 1685a06dd); AGENTS.md outranks the skill, so it still said the opposite. Maintainer, verbatim (from #26671): 「pr 你交给我批的价值是什么,我说同意你能合并吗」「所以总监席你呈给我完全没必要啊」.

No forced test edits. No changeset: the diff touches AGENTS.md and scripts/pm/** only, which publish nothing (skip-changeset).

Tests

No behaviour under test changed; the ratchet's own self-test and run are the check (below).

Acceptance notes

Verification

Head 2271cb17. node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 36 commands; every one ran and exited 0, and --ran reconciles.

Derived gates (36, all exit 0)
  • node scripts/check-closing-keyword-parity.mjs :: exit 0
  • node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0
  • node scripts/check-comment-mask-corpus.mjs :: exit 0
  • node scripts/check-declaration-mirrors.mjs :: exit 0
  • node scripts/check-declaration-mirrors.mjs --self-test :: exit 0
  • node scripts/check-self-test-wired.mjs :: exit 0
  • node scripts/check-self-test-wired.mjs --self-test :: exit 0
  • node scripts/check-self-test-workflow-commands.mjs :: exit 0
  • node scripts/check-self-test-workflow-commands.mjs --self-test :: exit 0
  • node scripts/check-whole-set-label-write.mjs :: exit 0
  • node scripts/check-whole-set-label-write.mjs --self-test :: exit 0
  • node scripts/ci/plan-test-core-shards.mjs --self-test :: exit 0
  • node scripts/pm/bare-root-worklist.mjs --self-test :: exit 0
  • pnpm check:agent-test-spelling :: exit 0
  • pnpm check:bash32-floor :: exit 0
  • pnpm check:ci-filter-parity :: exit 0
  • pnpm check:cli-command-ids :: exit 0
  • pnpm check:cross-package-test-inputs :: exit 0
  • pnpm check:docs-audit-scope :: exit 0
  • pnpm check:driver-memory-census :: exit 0
  • pnpm check:entry-guard :: exit 0
  • pnpm check:gitlink-declared :: exit 0
  • pnpm check:nul-bytes :: exit 0
  • pnpm check:parse-guard :: exit 0
  • pnpm check:pm-governed-merges :: exit 0
  • pnpm check:pm-governed-prose :: exit 0
  • pnpm check:pm-skill-id-lint :: exit 0
  • pnpm check:pm-skill-ratchet :: exit 0
  • pnpm check:pnpm-filter-targets :: exit 0
  • pnpm check:pnpm-flag-spellings :: exit 0
  • pnpm check:ratchet-remedy-authority :: exit 0
  • pnpm check:refd-timer-probe :: exit 0
  • pnpm check:required-contexts :: exit 0
  • pnpm check:scripts-symbol-anchors :: exit 0
  • pnpm check:watch-hint-literal :: exit 0
  • pnpm check:pm-dispatch-gates :: exit 0

--ran: Run reconciliation — 36 derived, 36 run, 0 NOT-MEASURED, 0 UNRUN. (a derived zero: all 36 recorded an exit code)

check:pm-skill-ratchet
  • self-test: ✓ check-skill-line-ratchet self-test: 164 cases pass.
  • run: every row green; decision-analysis.md 49 (ceiling 49; headroom 0), lanes/director.md 87 (ceiling 87; headroom 0).

Generated by Claude Code

… 14; pin two skill line ceilings

The maintainer ruled that a Tier H approval is not routed through the
director seat as a batch. The pm-dispatch skill already says so; Prime
Directive 14 still required the director to request the word as ONE
batch of at most five rows. That clause is deleted; the owning seat
lands after the approval and the click stays the maintainer's.

The decision-analysis.md and lanes/director.md line ceilings follow the
measured counts (50 to 49, 88 to 87) so the freed lines are banked.

Claude-Session: https://claude.ai/code/session_01ADHkmQSSjxyjrgFc2uWEBL
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 27, 2026
@github-actions github-actions Bot added size/xs documentation Improvements or additions to documentation labels Oct 27, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对

ACCEPT · domain:skills#1 · session_01ADHkmSrRBdu9MdC6fc33Uu · head 2271cb17 · 2026-10-27T15:01Z

  1. 形态 — Tier H (AGENTS.md): Prime Directive 14 loses only the clause 「the director seat requests the word as ONE batch of at most five rows,」; the sentence now ends 「…later pushes included; the click stays the maintainer's.」 and 「Tier S (…: all of」 starts the next line (joining would reach 122 columns), no other line re-wrapped. scripts/pm/check-skill-line-ratchet.mjs: two rows pinned at the measurement, decision-analysis.md 50→49 and lanes/director.md 88→87.
  2. 前提实测 — seat read the diff on the head: git grep "batch of at most five" AGENTS.md .claude → 0; the reference files are 49 / 87 lines on the base after PR docs(pm-dispatch): the director seat stops presenting governed drafts in a ruling batch #26693, so both rows sit at headroom 0.
  3. 门禁 check-runs — dev ran the 36 derived families on the head, all exit 0 (--ran 36/36, 0 NOT-MEASURED, 0 UNRUN), the line-ratchet self-test included; CI on the head is read again before landing.
  4. 接受的偏差 — none of substance; reviewers requested through the relay (os-zhuang, hotlong), not MCP, per the standing order.
  5. 范围外去向 — none. Skills-docs: none. Contract review at CONTRACT_REVIEW_TIER (rules face): requested from the director seat.
  6. 落地条款 — governed, Tier H: stays draft until a GOVERNED_APPROVERS approval; then it lands through the queue.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 2271cb17d42e54e12338472112f1fba15fe132f6
Local-runs: none
Scope: AGENTS.md + scripts/pm/check-skill-line-ratchet.mjs, .claude/skills/pm-dispatch/references/lanes/director.md, .claude/skills/pm-dispatch/references/decision-analysis.md

Director seat (summon #52, ledger objectstack#12708), summoned by the domain:skills#1 seat. This PR carries the two should-fixes this seat named in its #26693 record (6442969109); the review is of the diff against card #26697 (class ③, the maintainer's 「pr 你交给我批的价值是什么,我说同意你能合并吗」「所以总监席你呈给我完全没必要啊」), read-only at the head above: the diff, the card, the seat's ACCEPT 6445433157, the head tree (fetched, read with git show / git grep), the head's check runs. AGENTS.md is a governed-register row ⇒ the rules face, CONTRACT_REVIEW_TIER (Tier H: lands on a GOVERNED_APPROVERS approval, not on this record). Served at CONTRACT_REVIEW_TIER. The rule under review concerns this seat's own duty; judged against the maintainer's words and AGENTS.md's own structure, named so the record is read with that in view. The seat records; it does not approve, ready, queue or merge.

① Derived judgments

  • Exactly the clause the card names is gone, nothing else in Prime Directive 14 moves. Head AGENTS.md:279 「…that word is spent once per PR — the OWNING seat then lands it, later pushes included; the click stays the maintainer's.」 and 「Tier S (席内达档复核落地: all of」 opens line 280. GOVERNED_APPROVERS, the four bans, the Tier S arm (record at CONTRACT_REVIEW_TIER + PASS + green ⇒ owning seat lands through the queue) and the post-merge audit sentence are byte-unchanged in the hunk's context. git grep on the head for 「five rows」 / 「batch of at most」 / 「requests the word」 over AGENTS.md, .claude/, docs/adr/: no hit.
  • AGENTS.md and the skill now say one thing. After docs(pm-dispatch): the director seat stops presenting governed drafts in a ruling batch #26693 (merged 2026-10-27T14:16Z, 1685a06d, in this head's history), director.md:57–58 says four-pieces check, no batch, no chat 「同意」; AGENTS.md no longer says the opposite. The disagreement this seat flagged in docs(pm-dispatch): the director seat stops presenting governed drafts in a ruling batch #26693 ③ is closed by the carrier that card named.
  • Line budget held without widening. AGENTS.md stays 1112 lines (ratchet row ['AGENTS.md', 1112]); the 「Tier S」 fragment moves to the next line's start because the joined line would reach 122 columns — the only way to delete a mid-sentence clause from a wrapped paragraph without re-wrapping any untouched line, and the diff shows none re-wrapped.
  • The two ratchet pins follow the measurement. decision-analysis.md 50 → 49, lanes/director.md 88 → 87; the files measure 49 / 87 on this head (post-docs(pm-dispatch): the director seat stops presenting governed drafts in a ruling batch #26693), so both rows return to the file's own convention "landed count, headroom 0", which lowers only ("lowering is always legitimate"). The leading comments of both rows keep their history; no ruling is needed for a lowering.
  • The card's optional clause (name the relay pr_request_reviewers as where the request comes from) is not taken: AGENTS.md says nothing about who requests the review, and director.md:57 already does. A pointer AGENTS.md never had is not owed. Right to leave out.

② Semver level

AGENTS.md and scripts/pm/** publish nothing; skip-changeset; Clause-②: no, Metadata-protocol: none in the body. No level owed. Correct.

③ Boundary flags

  • Governed path (AGENTS.md, Tier H): no approval yet; draft; os-zhuang, hotlong requested through the relay. This seat's account is not a GOVERNED_APPROVERS member; this record is not an approval and does not lift Tier H.
  • Check runs on 2271cb17 at this record: 15 success (incl. Governed Surface Queue Guard, Lint · scoped · tooling self-tests, Lint · ESLint, the PR-body guards, Test UI), 17 expected skips, 8 still in_progress (Lint · repo & tooling gates — home of check:pm-skill-ratchet, whose self-test and run the dev reports green on this head — Lint · CI, release & engine gates, Type Check ×4, Test Core 2 shards). Nothing red; a red among the pending ones re-opens this record.
  • Concurrent edit, named by the dev: open PR chore(ui-merge): clear the objectui leftovers after the ui/ merge (#25753) #26598 (ui-merge leftovers) also touches decision-analysis.md, lanes/director.md and the ratchet file, on different rows. Whichever lands second re-measures the two files and re-pins; the body commits this PR to that. Not a must-fix; the queue serialises it.
  • Dev deviations: none beyond the relay-requested reviewers. The ACCEPT's readings (grep 0, 49 / 87 on base, 36 families exit 0) match this seat's reads of the head tree.

④ Design judgment

  • AGENTS.md PD14 against the maintainer's words and the directive's own structure: the Tier H sentence keeps every rule that is a gate (who may approve, once per PR, owning seat lands, click is the maintainer's) and loses only the sentence that described a relay the maintainer said has no value. The directive's shape — the register tiers the landing, Tier H = human approval, Tier S = at-tier record — is untouched, so no reader of AGENTS.md loses a rule they need to land a PR; the request path now lives where the duty does (director.md:57). Holds; nothing to break.
  • check-skill-line-ratchet.mjs as the gate behind the two skill files: pinning at the measurement restores the property the file promises for every row (a line cannot be added unmetered), which docs(pm-dispatch): the director seat stops presenting governed drafts in a ruling batch #26693 had left at headroom 1 outside its own surface. Holds.

Implemented-by: claude/project-thread-qilewq
Reviewed-by: session_01ADHkmQr732toX135tyo5zs

VERDICT: PASS


Generated by Claude Code

@os-zhuang
os-zhuang marked this pull request as ready for review October 27, 2026 15:08
@os-zhuang
os-zhuang enabled auto-merge October 27, 2026 15:08
@os-zhuang
os-zhuang added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 0f3d068 Oct 27, 2026
44 checks passed
@os-zhuang
os-zhuang deleted the claude/project-thread-qilewq branch October 27, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AGENTS.md: Prime Directive 14 drops "the director seat requests the word as ONE batch of at most five rows"

3 participants