Repository navigation
chore: delete the 211 inert no-explicit-any eslint-disable comments outside ui/ - #26252
Conversation
…de ui/ The root ESLint config never loads @typescript-eslint/eslint-plugin and `pnpm lint` runs with --no-inline-config, so these 211 comments in 66 files disabled a rule nobody runs. Delete them: a whole-line eslint-disable-next-line comment goes with its line, a trailing eslint-disable-line comment is cut from the end of its line. No rule, plugin, config or baseline changes; nothing under ui/. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D8CEyQZUZgQM1xXhoZeKgb
…-6od3f3 # Conflicts: # packages/verify/src/harness.org-context.test.ts
📓 Docs Drift Check2 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to list — not a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run. What this run could not see
Coarse fallback — 7 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): Which tree this was computed onThis run read A worktree cut from an older # while this PR is open — GitHub drops the merge commit once it closes
git fetch origin f603dab74d17cbdac6c88f54df569c30076fd1b6 && git checkout f603dab74d17cbdac6c88f54df569c30076fd1b6
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin a1477dec8a216229750b4404fc20cd07d6f2907e cd984c9181f8772310e6c2047c827080164729ab && git checkout -B drift-repro a1477dec8a216229750b4404fc20cd07d6f2907e && git merge --no-ff cd984c9181f8772310e6c2047c827080164729ab
node scripts/docs-audit/affected-docs.mjs --json a1477dec8a216229750b4404fc20cd07d6f2907e |
席位核对 · ACCEPT · devx seat 2 · 2026-10-26T17:14ZSeat
Generated by Claude Code |
Requested by Steve · project thread
Fixes #26082
Clause-②: no
Metadata-protocol: none
What changed
Ruling 6417062243, letter C: delete the 211
@typescript-eslint/no-explicit-anydisable comments outsideui/. They are inert twice over: the rooteslint.config.mjsnever loads@typescript-eslint/eslint-plugin, andpnpm lintrunseslint . --no-inline-config. Nothing is installed, no rule is added,eslint.config.mjsand every baseline are untouched, and nothing underui/is touched (#25918 owns that tree).Every comment named only this one rule, so no comment needed a partial edit. Two shapes, both handled mechanically:
// eslint-disable-next-line @typescript-eslint/no-explicit-any// eslint-disable-line @typescript-eslint/no-explicit-anyThere were no block
/* eslint-disable … */comments on this rule outsideui/.packages/qa/dogfoodpackages/verifypackages/plugins/plugin-securitypackages/plugins/plugin-authpackages/corepackages/runtimepackages/types65 of the 66 files are tests; the one source file is
packages/verify/src/handle.ts(3 comment lines).How it was verified (head
cd984c91)git grep -c 'eslint-disable.*@typescript-eslint/no-explicit-any' -- ':!ui'was 66 files / 211 comments onorigin/main(601c7738at start, still 211 ate6dfeb08); on this head it matches nothing (exit 1).eslinttext is added; no file loses its final newline.pnpm lintbefore and after, output diff empty. Before: a clean worktree atorigin/maine6dfeb08; after: this head. Both exit 0, and the outputs are identical once the checkout path is normalised. The same pair was also run on the first head (c91379fbagainst601c7738), also identical.pnpm --filter … run typecheckon the seven touched packages (core,plugin-auth,plugin-security,dogfood,runtime,types,verify), on this head after a fullpnpm build(119/119 tasks): all sevenDone, lock VERDICT command-exit 0.vitest run --maxWorkers=2under the verify lock, every VERDICT command-exit 0:types29 files / 781 tests;verify46 / 393;plugin-auth198 / 3,779 (10 skipped);plugin-security225 / 4,920 (45 skipped);core121 / 2,778;runtime455 / 7,408 (19 skipped) (core,runtimeandtypeswith--project local, theirtestscript's project).dogfood: the 41 touched files only, 41 / 345 passed; the whole dogfood battery is CI's (no!in the title and no(narrowing)arm). The same set was green on the first head too.node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 67 commands; all 67 exit 0, each exit taken before any pipe;--ranreconciliation:67 run, 0 NOT-MEASURED, 0 UNRUN, a derived zero. (check-plugin-teardown-shape.mjs --self-testneeds its pinned fixture commit, fetched into this shallow clone first;check:dts-closureandcheck:dual-build-cjs-loadsread every package'sdist/, so they were read after the full build.)node scripts/pm/check-governed-merges.mjs --teston the 66 paths:0 of 66 path(s) hit the register.skip-changeset. Only comments are deleted: 65 files are tests outside every package'sfiles[], and inhandle.tsthe three deleted lines are line comments, so no symbol, type or runtime behaviour in@objectstack/verify'sdistchanges.Acceptance notes
origin/main: test(verify): pay the first boot load at collection and share one boot per configuration in two harness suites #26175 had changedpackages/verify/src/harness.org-context.test.ts. On that file this branch takes main's version and deletes its 4 comments the same way; the branch's delta against main is still 66 files, +45 / −211.pnpm typecheckwas run on the seven touched packages, not the whole workspace; the whole-workspace run is the requiredTypeScript Type Checkjob on this PR.no-explicit-anybaseline over non-testsrc/**) is not part of this PR, as the ruling says; a later card can cite [Decision] Root ESLint never loads @typescript-eslint/eslint-plugin, so no-explicit-any is a rule nobody runs: 1,922 as-any sites in non-test source and 211 eslint-disable comments for an absent rule — add a per-file ratchet, or not #26082 if the maintainer names that gate.Generated by Claude Code