Repository navigation
Commit 443f563
chore: delete the 211 inert no-explicit-any eslint-disable comments outside ui/ (#26252)
<!-- claude-projects-attribution: {"github_login":"os-steve"} -->
_Requested by **Steve** · [project
thread](https://claude.ai/code/project/chan_01FdL1XeUyvVNxLreh3F4Qi9?thread=cmsg_01FdL1XeUyvVNxLreh3F4Qi9CmR52V4tPmUNSq3TokKYLs)_
Fixes #26082
Clause-②: no
Metadata-protocol: none
## What changed
Ruling 6417062243, letter **C**: delete the 211
`@typescript-eslint/no-explicit-any` disable comments outside `ui/`.
They are inert twice over: the root `eslint.config.mjs` never loads
`@typescript-eslint/eslint-plugin`, and `pnpm lint` runs `eslint .
--no-inline-config`. Nothing is installed, no rule is added,
`eslint.config.mjs` and every baseline are untouched, and nothing under
`ui/` is touched (#25918 owns that tree).
Every comment named only this one rule, so no comment needed a partial
edit. Two shapes, both handled mechanically:
| Shape | Count | Edit |
|---|---|---|
| a whole-line `// eslint-disable-next-line
@typescript-eslint/no-explicit-any` | 166 | the line is deleted, no
blank line left in its place |
| a trailing `// eslint-disable-line @typescript-eslint/no-explicit-any`
| 45 | the comment and the whitespace before it are cut, the code is
kept byte for byte |
There were no block `/* eslint-disable … */` comments on this rule
outside `ui/`.
| Package | Files | Comments |
|---|---|---|
| `packages/qa/dogfood` | 41 | 120 |
| `packages/verify` | 15 | 32 |
| `packages/plugins/plugin-security` | 6 | 41 |
| `packages/plugins/plugin-auth` | 1 | 10 |
| `packages/core` | 1 | 6 |
| `packages/runtime` | 1 | 1 |
| `packages/types` | 1 | 1 |
65 of the 66 files are tests; the one source file is
`packages/verify/src/handle.ts` (3 comment lines).
## How it was verified (head `cd984c91`)
- **Grep.** `git grep -c
'eslint-disable.*@typescript-eslint/no-explicit-any' -- ':!ui'` was 66
files / 211 comments on `origin/main` (`601c7738` at start, still 211 at
`e6dfeb08`); on this head it matches nothing (exit 1).
- **Diff shape.** Every removed line contains the comment (0 removed
lines without it); the 45 added lines are exactly the 45
trailing-comment lines with the comment cut (compared line for line); no
`eslint` text is added; no file loses its final newline.
- **`pnpm lint` before and after, output diff empty.** Before: a clean
worktree at `origin/main` `e6dfeb08`; after: this head. Both exit 0, and
the outputs are identical once the checkout path is normalised. The same
pair was also run on the first head (`c91379fb` against `601c7738`),
also identical.
- **Typecheck.** `pnpm --filter … run typecheck` on the seven touched
packages (`core`, `plugin-auth`, `plugin-security`, `dogfood`,
`runtime`, `types`, `verify`), on this head after a full `pnpm build`
(119/119 tasks): all seven `Done`, lock VERDICT command-exit 0.
- **Tests on this head.** Each package's `vitest run --maxWorkers=2`
under the verify lock, every VERDICT command-exit 0: `types` 29 files /
781 tests; `verify` 46 / 393; `plugin-auth` 198 / 3,779 (10 skipped);
`plugin-security` 225 / 4,920 (45 skipped); `core` 121 / 2,778;
`runtime` 455 / 7,408 (19 skipped) (`core`, `runtime` and `types` with
`--project local`, their `test` script's project). `dogfood`: the 41
touched files only, 41 / 345 passed; the whole dogfood battery is CI's
(no `!` in the title and no `(narrowing)` arm). The same set was green
on the first head too.
- **Gates.** `node scripts/pm/dispatch-gates.mjs --commands --repo
objectstack-ai/objectstack` derived 67 commands; all 67 exit 0, each
exit taken before any pipe; `--ran` reconciliation: `67 run, 0
NOT-MEASURED, 0 UNRUN`, a derived zero.
(`check-plugin-teardown-shape.mjs --self-test` needs its pinned fixture
commit, fetched into this shallow clone first; `check:dts-closure` and
`check:dual-build-cjs-loads` read every package's `dist/`, so they were
read after the full build.)
- **Governed surface.** `node scripts/pm/check-governed-merges.mjs
--test` on the 66 paths: `0 of 66 path(s) hit the register`.
- **Changeset:** none, this carries `skip-changeset`. Only comments are
deleted: 65 files are tests outside every package's `files[]`, and in
`handle.ts` the three deleted lines are line comments, so no symbol,
type or runtime behaviour in `@objectstack/verify`'s `dist` changes.
## Acceptance notes
- One merge of `origin/main`: #26175 had changed
`packages/verify/src/harness.org-context.test.ts`. On that file this
branch takes main's version and deletes its 4 comments the same way; the
branch's delta against main is still 66 files, +45 / −211.
- `pnpm typecheck` was run on the seven touched packages, not the whole
workspace; the whole-workspace run is the required `TypeScript Type
Check` job on this PR.
- The measurement option A would have bought (a per-file shrink-only
`no-explicit-any` baseline over non-test `src/**`) is not part of this
PR, as the ruling says; a later card can cite #26082 if the maintainer
names that gate.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01D8CEyQZUZgQM1xXhoZeKgb)_
Co-authored-by: Claude <noreply@anthropic.com>1 parent dc71845 commit 443f563
66 files changed
Lines changed: 45 additions & 211 deletions
File tree
- packages
- core/src/utils
- plugins
- plugin-auth/src
- plugin-security/src
- objects
- qa/dogfood/test
- runtime/src
- types/src
- verify/src
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
| |||
84 | 83 | | |
85 | 84 | | |
86 | 85 | | |
87 | | - | |
88 | 86 | | |
89 | | - | |
90 | 87 | | |
91 | 88 | | |
92 | | - | |
93 | 89 | | |
94 | 90 | | |
95 | 91 | | |
96 | 92 | | |
97 | | - | |
98 | 93 | | |
99 | 94 | | |
100 | 95 | | |
101 | 96 | | |
102 | | - | |
103 | 97 | | |
104 | 98 | | |
105 | 99 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | 89 | | |
91 | 90 | | |
92 | 91 | | |
93 | | - | |
94 | 92 | | |
95 | 93 | | |
96 | 94 | | |
| |||
107 | 105 | | |
108 | 106 | | |
109 | 107 | | |
110 | | - | |
111 | 108 | | |
112 | 109 | | |
113 | 110 | | |
114 | | - | |
115 | 111 | | |
116 | 112 | | |
117 | 113 | | |
118 | 114 | | |
119 | 115 | | |
120 | 116 | | |
121 | 117 | | |
122 | | - | |
123 | 118 | | |
124 | | - | |
125 | 119 | | |
126 | 120 | | |
127 | 121 | | |
128 | 122 | | |
129 | | - | |
130 | 123 | | |
131 | 124 | | |
132 | 125 | | |
| |||
136 | 129 | | |
137 | 130 | | |
138 | 131 | | |
139 | | - | |
140 | 132 | | |
141 | 133 | | |
142 | 134 | | |
| |||
251 | 243 | | |
252 | 244 | | |
253 | 245 | | |
254 | | - | |
255 | 246 | | |
256 | 247 | | |
257 | 248 | | |
| |||
274 | 265 | | |
275 | 266 | | |
276 | 267 | | |
277 | | - | |
278 | 268 | | |
279 | 269 | | |
280 | 270 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
94 | 93 | | |
95 | 94 | | |
96 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
94 | 93 | | |
95 | | - | |
96 | 94 | | |
97 | 95 | | |
98 | 96 | | |
| |||
103 | 101 | | |
104 | 102 | | |
105 | 103 | | |
106 | | - | |
107 | 104 | | |
108 | 105 | | |
109 | 106 | | |
| |||
115 | 112 | | |
116 | 113 | | |
117 | 114 | | |
118 | | - | |
119 | 115 | | |
120 | 116 | | |
121 | 117 | | |
| |||
126 | 122 | | |
127 | 123 | | |
128 | 124 | | |
129 | | - | |
130 | 125 | | |
131 | 126 | | |
132 | 127 | | |
| |||
138 | 133 | | |
139 | 134 | | |
140 | 135 | | |
141 | | - | |
142 | 136 | | |
143 | | - | |
144 | 137 | | |
145 | 138 | | |
146 | 139 | | |
147 | 140 | | |
148 | | - | |
149 | 141 | | |
150 | 142 | | |
151 | 143 | | |
| |||
154 | 146 | | |
155 | 147 | | |
156 | 148 | | |
157 | | - | |
158 | 149 | | |
159 | | - | |
160 | 150 | | |
161 | 151 | | |
162 | 152 | | |
| |||
167 | 157 | | |
168 | 158 | | |
169 | 159 | | |
170 | | - | |
171 | 160 | | |
172 | 161 | | |
173 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
77 | 76 | | |
78 | | - | |
79 | 77 | | |
80 | 78 | | |
81 | 79 | | |
| |||
102 | 100 | | |
103 | 101 | | |
104 | 102 | | |
105 | | - | |
106 | 103 | | |
107 | 104 | | |
108 | 105 | | |
| |||
114 | 111 | | |
115 | 112 | | |
116 | 113 | | |
117 | | - | |
118 | 114 | | |
119 | 115 | | |
120 | 116 | | |
| |||
135 | 131 | | |
136 | 132 | | |
137 | 133 | | |
138 | | - | |
139 | 134 | | |
140 | 135 | | |
141 | 136 | | |
| |||
147 | 142 | | |
148 | 143 | | |
149 | 144 | | |
150 | | - | |
151 | 145 | | |
152 | 146 | | |
153 | 147 | | |
| |||
159 | 153 | | |
160 | 154 | | |
161 | 155 | | |
162 | | - | |
163 | 156 | | |
164 | 157 | | |
165 | 158 | | |
| |||
196 | 189 | | |
197 | 190 | | |
198 | 191 | | |
199 | | - | |
200 | 192 | | |
201 | | - | |
202 | 193 | | |
203 | 194 | | |
204 | 195 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
121 | 120 | | |
122 | | - | |
123 | 121 | | |
124 | 122 | | |
125 | 123 | | |
126 | 124 | | |
127 | | - | |
128 | 125 | | |
129 | 126 | | |
130 | 127 | | |
131 | 128 | | |
132 | 129 | | |
133 | 130 | | |
134 | 131 | | |
135 | | - | |
136 | 132 | | |
137 | 133 | | |
138 | 134 | | |
| |||
156 | 152 | | |
157 | 153 | | |
158 | 154 | | |
159 | | - | |
160 | 155 | | |
161 | 156 | | |
162 | 157 | | |
| |||
174 | 169 | | |
175 | 170 | | |
176 | 171 | | |
177 | | - | |
178 | 172 | | |
179 | 173 | | |
180 | | - | |
181 | 174 | | |
182 | 175 | | |
183 | 176 | | |
| |||
399 | 392 | | |
400 | 393 | | |
401 | 394 | | |
402 | | - | |
403 | 395 | | |
404 | 396 | | |
405 | 397 | | |
| |||
411 | 403 | | |
412 | 404 | | |
413 | 405 | | |
414 | | - | |
415 | 406 | | |
416 | 407 | | |
417 | 408 | | |
| |||
422 | 413 | | |
423 | 414 | | |
424 | 415 | | |
425 | | - | |
426 | 416 | | |
427 | 417 | | |
428 | 418 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
156 | 155 | | |
157 | 156 | | |
158 | 157 | | |
| |||
297 | 296 | | |
298 | 297 | | |
299 | 298 | | |
300 | | - | |
301 | 299 | | |
302 | 300 | | |
303 | 301 | | |
| |||
367 | 365 | | |
368 | 366 | | |
369 | 367 | | |
370 | | - | |
371 | 368 | | |
372 | 369 | | |
373 | 370 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
117 | 116 | | |
118 | | - | |
119 | 117 | | |
120 | 118 | | |
121 | 119 | | |
| |||
131 | 129 | | |
132 | 130 | | |
133 | 131 | | |
134 | | - | |
135 | 132 | | |
136 | 133 | | |
137 | 134 | | |
| |||
266 | 263 | | |
267 | 264 | | |
268 | 265 | | |
269 | | - | |
270 | 266 | | |
271 | 267 | | |
272 | 268 | | |
273 | 269 | | |
274 | | - | |
275 | 270 | | |
276 | 271 | | |
277 | 272 | | |
| |||
280 | 275 | | |
281 | 276 | | |
282 | 277 | | |
283 | | - | |
284 | 278 | | |
285 | 279 | | |
286 | 280 | | |
| |||
302 | 296 | | |
303 | 297 | | |
304 | 298 | | |
305 | | - | |
306 | 299 | | |
307 | 300 | | |
308 | 301 | | |
| |||
0 commit comments