docs(dogfood): re-anchor the dead tracker citations in packages/qa/dogfood's files outside src to the commits and ADR that decided them - #20898
Merged
objectstack-fleet[bot] merged 1 commit intoSep 30, 2026
Conversation
…gfood's files outside src to the commits and ADR that decided them Comment prose only, in test/** and vitest.config.ts: every comment site whose tracker number answers 404 now cites the commit in this repository's history that decided what the line describes, or the ADR clause that records the ruling (ADR-0029 D9.2a). String literals, describe/it titles and messages are untouched. Every file keeps its line count. Claude-Session: https://claude.ai/code/session_01VvcEokUG1tvVxkceYfR5XB Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift Check
What this run could not see
Coarse fallback — 2 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
objectstack-fleet
Bot
deleted the
claude/issue-20594-qa-dogfood-citations
branch
September 30, 2026 17:21
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #20594
Clause-②: no
What changed
This is stage 15 of the
domain:clilane's dead-citation sweep:packages/qa/dogfood's dead citations in files outsidesrc/**, the largest package left after stage 14 (claim5914651671). The package has nosrc/at all, so the surface is itstest/**,README.md,tsconfig.jsonandvitest.config.ts.Every comment site on that surface whose tracker number answers 404 now cites the object that decided what the line describes, in ruling C+D's form C (comment
5749154545on #19123): the ADR clause when one records the ruling, otherwise the commit in this repository's history. Stages 1 to 14 of this card are the precedents; the latest is PR #20883.vitest.config.tsand 26 undertest/**: 21 test files, 4 helper modules and 1 fixture.describe/ittitles and messages are untouched. They belong to runtime strings in thedomain:clipackages carry tracker numbers (114 messages in 8 packages, 254 ledgered ids): this lane's share of the #20513 A/A burn-down #20752 (form D, fold5911936313); 28 such sites stay on this file list, listed in the acceptance notes.installAttachmentAccessHooksdoes not authorize an UNSCOPED multi-delete: no id + nowherereads as "nothing to authorize" anddeleteManyruns over the whole table #4757, driver-memory 完全没有行级租户隔离(#3724 的未修姊妹面):多租户下静默不隔离 #6915, [security]sys_accountstores live third-party OAuth access/refresh/id tokens as plain columns, and the object is API-readable #7987, [finding] An org-less test fixture cannot observe theorg_member-gated write floor, so a real 403 defect records as a PASSING cell #8074, The i18n catalog is resolved ahead of the document, so a tenant's own Studio rename never reaches either/meta/objectread — and neither do extension scalar overrides #8284, [finding] 79 of 82 dogfood fixtures boot org-less, and nothing has swept them for #8023's disarm now that a probe exists #8408, The #4757 unscoped multi-delete refusal on sys_attachment never fires through ObjectQL.delete — per-row hook dispatch bypasses it #9719, Measure whether /meta/* write routes refuse an unauthenticated (@anon) principal — server-side half of objectui#5828 #11373 and [finding] the silent partial-filter drop #17853 fixes in packages/cli is live in the seven other packages that declare vitestprojects#17978 all answer 200.── … ─────) is shortened by the characters its heading gained, never below one dash. Three of the five section headers keep their width;admin-route-nonadmin-refusal:339grows by 2 characters andtwo-doors-permission:81, which already ended in one dash, by 11.Census
Instrument. The card's gate does not read these files: its declared surface is
packages/**/src/**, andsurfaceForanswers null for all 27 touched paths (the controlpackages/cli/src/commands/init.tsanswerspackage-docblocks). So the census is taken by hand, with the gate's own grammar, as stage 14 took it:packages/qa/dogfoodoutsidesrc/**, withCHANGELOG.md(claim) andpackage.json(not on the claim's list) left out. That is 178 files.extractCitationsfromscripts/check-issue-citations.mjs, with its comment-prose projection for code and JSONC files and the whole file forREADME.md. The whole-file extraction minus the comment projection gives the string sites.namesThisRepository).GET /repos/objectstack-ai/objectstack/issues/N; 404 means dead.4edb61449b57ffb83b00660a9b247: 94 comment sites and 28 string sites in 13 files.README.mdcites fix(analytics): make organization timezone drive date-dimension bucketing (#1982) #2018 and fix(security)[P0]: enforce RLS on by-id writes — close member-edits-others'-records hole (#1985) #1994, andpackage.json's description cites fix(analytics): make organization timezone drive date-dimension bucketing (#1982) #2018, fix(security)[P0]: enforce RLS on by-id writes — close member-edits-others'-records hole (#1985) #1994 and fix: array field types persist + Field.time accepts time-of-day #2004. All answer 200.Per-number anchors
Each anchor was checked by blame on the site, and in the anchor's own message or diff. "Reused" names an earlier stage that gave the number the same anchor.
#6293c39a911aebuild-shaped-artifact.tsruns the real lowering, and no published surface grows (its subject names the card)src)#6483ee58392e1permission(and eight more types) toallowOrgOverride: false;allowRuntimeCreatestays open#846001a7337fc, which amends the ADR#8676d6e80b28bsys_account.passwordandprevious_password_hashesinternal#87112ce1eb41b#871160ade586eactiverows with nocovers, and why (matrix.ts:393)#8811d6e793507grant-validity-windowmatrix row (its subject names the card)#8839c25b2d52a#8919b5378550e/metapublish and rollback onmanage_metadata, with the enumeration pin#97971258dcaee#993479c46da90userMessagemarking, including the QuickJS side-channel#10243266436a7fPOST /automation/:name/togglejoins themanage_metadatawrite set (automation-toggle-tenant-scope:4)#1024302b41232dpackaged-activation-ledger-reach:291)#1094346d34ab7cfallbackImportbecomes a caller-supplied parameter#1099602b41232d#114776dd3e6968/admin/remove-userauthorizes before the break-glass guard (its message records "Ruled option A on" the card)#11530033a34c7cset_user_roleconsole action#116867131f12bfhasPlatformAdminStandingas the one authority#121767986d973fPUT /meta/:type/:section/:nameamong them. The ruling'sD3ordinal is kept beside it#12194311433f6b#13214cc837dbfeGET /ui/view/:object/:type; its diff writes these census lines and its message the 2026-08-30 ruling#16589555a89cbddriver-memoryrefuses a tenant-scoped call; its diff names the card at every seam#16659ecdfc9411F2ordinal is kept, as the trigger-schedule stage kept it#16687779710213#1785308f5f0e5a#19306f9e16d856ADR and ruling records. A grep of
docs/adrandscripts/adr-anchorsfor the 24 numbers finds three: #8460, #6483 and #10243. ADR-0029 D9.2a is the ruling for #8460 (it carries the number in its heading), so it is cited. The #6483 hits (ADR-0086, ADR-0094, ADR-0126 and two adr-anchors entries) and the #10243 hits (ADR-0126, ADR-0131) mention those landings as history; none records the ruling itself, so those two stay on the commit every earlier stage anchored them to. The control number7329finds 1 file in the same tree.Anchor checks:
git rev-parse --disambiguategives count 1 for each of the 24.merge-base --is-ancestoragainst4edb61449bexits 0 for all 24.255588bd36, the parent of the oldest anchoree58392e1(2026-08-09), exits 0. Negative control: the base as an ancestor ofee58392e1exits 1.Verification
All at head
57ffb83b00. Heavy runs went throughscripts/pm/os-verify-lock.shwithOS_VERIFY_LOCK_SLOT=issue-20594-dogfood.pnpm exec turbo run build --filter='@objectstack/dogfood^...' --concurrency=2→ 63 successful, 63 total (32 cached), lock verdict exit 0.shared-showcaseandisolated) and no tier split, so one run named all 21 touched test files plus the unit tests of the two touched helpers no touched test imports (authz-probe-blind-spot.test.ts, the census module's only importer, andenterprise-organizations.test.ts):pnpm --filter @objectstack/dogfood exec vitest run --maxWorkers=2 FILES→ Test Files 23 passed (23), Tests 317 passed (317), lock verdict command-exit 0.vitest.config.tsis loaded by that run.pnpm --filter @objectstack/dogfood typecheck(tsc --noEmit) → lock verdict command-exit 0.--listFilesOnlyshows 26 of the 27 touched files in the program; the 27th isvitest.config.ts.getChildren, JSDoc nodes skipped), base4edb61449bagainst head, 27 files, 52,502 base tokens: 0 files differ. Controls, in memory only: a comment inserted into each file, 0 of 27 differ; a statement appended, 27 of 27; one character flipped inside each file's firstStringLiteral, 27 of 27.pnpm check:nul-bytesexits 0.Gates
All at head
57ffb83b00, exit codes captured before any pipe.node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands, no paths, derives 53 commands for this change set (27 paths against merge base4edb61449b). Re-derived after two fetches oforigin/main(to00a92e18da, then33b6e8bece): the same 53, and none of the upstream commits touches a derivation input or a file here.pnpm check:dual-build-cjs-loadsfirst exited 3 (PREREQUISITE NOT MET, nodist/for 8 packages outside dogfood's build closure); afterpnpm exec turbo run build --filter='./packages/*' --filter='./packages/*/*' --concurrency=2(71 of 71, all cached) it exits 0.dispatch-gates --ranover the recordedCOMMAND :: exit CODElist → "53 derived, 53 run, 0 NOT-MEASURED, 0 UNRUN", exit 0.pnpm lint(repo-wideeslint . --no-inline-config, the family the derivation does not name) → exit 0, 2026-09-30T16:13:49Z to 16:18:00Z.node scripts/check-issue-citations.mjs(diff mode, in the 53) reads 0 files, because none of these paths is on its declared surface; the hand census above is the measurement for this surface.git merge-tree --write-treeof this head againstorigin/main33b6e8beceis clean.The 53 derived commands:
node scripts/check-ci-filter-parity.mjsnode scripts/check-closing-keyword-parity.mjsnode scripts/check-closing-keyword-parity.mjs --self-testnode scripts/check-comment-mask-adoption.mjsnode scripts/check-comment-mask-adoption.mjs --self-testnode scripts/check-comment-mask-corpus.mjsnode scripts/check-issue-citations.mjsnode scripts/check-keyed-text-bounds.mjsnode scripts/check-keyed-text-bounds.mjs --self-testnode scripts/check-platform-object-tenancy-census.mjsnode scripts/check-platform-object-tenancy-census.mjs --self-testnode scripts/check-plugin-teardown-shape.mjsnode scripts/check-plugin-teardown-shape.mjs --self-testnode scripts/check-registry-log-declared.mjsnode scripts/check-registry-log-declared.mjs --self-testnode scripts/check-rest-log-spy-declared.mjsnode scripts/check-rest-log-spy-declared.mjs --self-testnode scripts/check-system-context-census.mjsnode scripts/check-system-context-census.mjs --self-testnode scripts/check-undeclared-dep-imports.mjsnode scripts/check-undeclared-dep-imports.mjs --self-testnode scripts/docs-audit/check-affected-docs.mjsnode scripts/docs-audit/check-drift-comment.mjspnpm --filter @objectstack/spec run check:empty-statepnpm --filter @objectstack/spec run check:livenesspnpm --filter @objectstack/spec run check:strictness-ledgerpnpm --filter @objectstack/spec run check:variant-docspnpm check:cross-package-test-inputspnpm check:dispatcher-error-vocabularypnpm check:doc-authoringpnpm check:driver-memory-censuspnpm check:dts-closurepnpm check:dual-build-cjs-loadspnpm check:engine-double-contractpnpm check:gitlink-declaredpnpm check:issue-citationspnpm check:lean-entry-closurepnpm check:logger-receiver-detachpnpm check:nul-bytespnpm check:objectql-double-limitpnpm check:org-identifierpnpm check:page-declaration-shapepnpm check:published-filespnpm check:query-options-erasurepnpm check:refd-timer-probepnpm check:slot-lookuppnpm check:sourcemap-no-sources-contentpnpm check:test-source-aliaspnpm check:tier-file-adoptionpnpm check:type-check-coveragepnpm check:type-check-debtpnpm check:watch-hint-literalpnpm check:where-matcherAcceptance notes
@objectstack/dogfoodisprivate: true, so nothing here publishes; the PR carriesskip-changeset.objectstack buildcannot reuselowerCallables—JSON.stringify(stack)silently drops every callable instead #6293, ADR-0005:57 白名单表与注册表的分歧不止 flow:page/app/action/permission/tool/skill 六类 ADR 写 ❌ 而 allowOrgOverride:true,另有 dataset/book/position 三类表里没有却默认成了 true #6483, [security]sys_account.passwordandprevious_password_hashesserialize on the generic data API — to admins cross-user, and to the user themselves #8676, Does a DEACTIVATEDsys_positionstill receive sharing-rule shares?expandPositionUsersnever reads the catalogue row, so today it does #8710, The ADR-0056 D10 authz conformance matrix has no row for the grant-catalogueactiveflag, and its completeness check cannot notice #8711, [finding] The ADR-0056 D10 authz matrix has no row for the ADR-0091 grant validity windows either — a second instance of #8711's gap #8811, contract: a hook refusal has no way to mark its message user-facing — the console's 403 substitution (ruled in #3821) needs a producer-side opt-in channel #9934, Decide whether POST /api/v1/automation/:name/toggle belongs in the manage_metadata write set — it mutates flow enablement with no authoring capability #10243, [security][finding] 同一 break-glass 守卫的第三张面孔:/admin/remove-user 上全局 hooks.before 跑在 adminMiddleware 之前,已认证的非管理员即可触达其查找与拒绝 #11477, fix(platform-objects): retire the set_user_role action from sys_user #11530, fix(auth): resolve the id-shaped platform-admin question in one place #11686, Retiresys_scim_provider— consumer sweep first, no data migration (leg 1a of #11632, ruled on #11693) #11757, Ban/in metadata item names — retire compound-name addressing (maintainer-ruled direction): census, migration surface, staged plan #12176, authz-conformancediscover()reaches 1 of 17 route registrars in rest-server.ts — the ratchet's route-completeness guarantee is false for 66 of 85 mounted routes #13260, [finding] The InMemory driver silently ignores the engine's tenant scope for objects that OMIT atenancyblock — its guard only refuses an explicitenabled: true, so memory-driver runs show cross-organization rows a SQL driver refuses #16589, A schedule-triggered flow'snotifydelivers nothing on a multi-organization install: the run carries no organization, so the tenant-scoped inbox/delivery writes are refused (#8844) while the run reads healthy #16659). They aredescribe/ittitles and string values such as the matrix rows'note:text. They belong to runtime strings in thedomain:clipackages carry tracker numbers (114 messages in 8 packages, 254 ledgered ids): this lane's share of the #20513 A/A burn-down #20752 (form D).660a9b247, report5914100460): 17 comment sites in the other lane packages outsidesrc/**(plugin-hono-server4;plugin-dev,clientandqa/vitest-filter-preflight2 each;cloud-connection,mcp,qa/downstream-contract,rest,runtime,typesandverify1 each), the fiveclisites with no deciding commit, and the 55 off-list sites stage 14 listed. None of them is touched here.packages/qa/dogfood(all 10 open PRs' file lists read at 2026-09-30T15:56:00Z). The in-flight branch for automation: the create and update doors register a flow in the engine only and persist nothing, so a created flow is gone after a restart and an update is overwritten by the stored definition #20862 adds one new file there,automation-authoring-doors-durable.dogfood.test.ts, which is not among these 27.Generated by Claude Code