Skip to content

docs(spec): re-anchor the dead tracker citations in migrations/entries to the commits that decided them (stage 10) - #20750

Merged
objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-20234-migrations-citations
Sep 30, 2026
Merged

objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-20234-migrations-citations

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #20234

Clause-②: no

Stage 10 of the dead-citation sweep: the migration registry's hand-written entries. Every tracker number in packages/spec/src/migrations/entries/** that no longer exists on the board now cites the commit that decided it, in ruling C+D form C (ruling 5749154545 on #19123). Where the number alone carried the meaning, the line now says what was decided. That is 131 sites over 21 numbers. All of them are comments; the entries' string literals carry no dead number. migrations/registry.ts moves only by gen:migration-registry. No entry id, literal, order, conversionIds or code token moves, and no live citation is removed.

Boundary

  • In: all of entries/**. The gate's census reads 117 sites there, under the claim's ~120 slicing threshold, so there is no slice. My raw walk finds 14 more comment sites that the census does not count (see Census below), which gives 131 in total. They are the same dead card on the line after a counted site, plus one README line, so they are rewritten with it.
  • Regenerated only: migrations/registry.ts, 128 lines. spec-changes.json and docs/protocol-upgrade-guide.md do not move, because entry comments are never projected into them. Both check: scripts pass with no regeneration.
  • Out, per the claim: registry.ts's hand-written parts. They still hold 13 dead sites, listed under Acceptance notes. The six 18.*-unit-in-key.ts entries that PR chore(objectui): bump the console pin to db11afd4967c (carries objectui#11119, the objectui#11105 fix) #20706 edits carry no dead site, and I did not touch them. I did not touch conversions/ or other lanes' sites.

The anchors (one per number, reused from earlier stages where they anchored the same number)

number sites anchor what the rewritten line says it decided
#13135 26 (13 are re-charter #13135) commit 9e0ba21 retires the paper metadata-customization protocol; re-charter of #12057, which stays
#8495 23 commit 4bfe1a5 (PR #8666 kept) the precedent: the first 17.x-line narrowing registered under protocol 18 (its own second commit says so)
#8715 16 commit 2c86fe3 the ApiKeySchema retirement; its message names the "route 3" kit (no carrier key, no tombstone, no D2)
#14691 11 commit b3a63d3 retires the ten inert RestServerConfig keys
#10724 11 commit be21955 retires the nine dead contributes members
#14369 10 commit a3d5724 the liveness census that recorded the 15 dead rows
#10485 6 commit 35ad101 retires the themes carrier and ThemeSchema
#11846 5 commit 0c2334f retires preview mode; its own text carries the ruling record (#12428 kept)
#14676 5 commit 13c48c2 retires connector.errorMapping
#11332 3 commit dce5cd4 retires the manifest's three dead containers
#6361 2 commit 90bbf25 retires the notification-list cursor on both halves
#10627 2 commit be21955 that commit records the controlled monorepo census
#14365 2 commit f60ab90 the open z.partialRecord proposal that commit's changeset recorded; the retirement leaves no record to reshape
#14526 2 commit db16b94 the landing of the client envelope convergence (anchor block, and the README's measured case)
#6363 1 commit 17d0954 "ruled jointly with the unreadCount fix"
#6239 1 commit f549a0d the ViewProtocol retirement sweep
#10726 1 commit bc56e18 retires contributes.routes (Option B)
#10812 1 commit be21955 "the cloud census", whose 2026-08-24 reading @5b5925a that commit's message records
#9041 1 commit d491625 the url-branch refinement (#9147, live, stays)
#14996 1 commit db16b94 the ADR-0087 registration, which landed in the same squash (its body: "Registration requested on #14996")
#14312 1 commit e944fdb the oauth.* binding, which left applications.delete out as a behaviour change (PR #15445 kept)

Two lines change without a number, so the sentence still reads: patterns' follow-on line and the oauth anchor block's continuation line. In total 133 lines are removed and 133 added in 86 files, and every file is balanced.

Verification record (final head 1ee5841c09; base fbec216e2d)

Census (the gate's own check-issue-citations.mjs --census --json, board enumerated, 186 pages):

subtree base (00:21Z, frontier #20740) head (01:18Z, frontier #20743)
entries/retired-keys 73 0
entries/retired-defs 40 0
entries/semantic 4 0
registry.ts, generated regions 114 0
registry.ts, hand-written parts 2 2
chain.ts, types.ts, index.ts, spec-changes.ts, tests 0 0
migrations/ 233 2
packages/spec/src 235 4

Residue (scratch walker over the TypeScript parser, per file, base vs head, 86 .ts files):

  • The file with every comment range cut out, everything else byte for byte, is IDENTICAL.
  • The leaf-token stream is IDENTICAL: 38,417 tokens, aggregate 67c1f6db944e93ed.
  • Controls mutate the head text in memory only, 259 of 259 as expected:
    • Expected identical: a comment insertion in every file.
    • Expected to differ: a string-literal edit, a template-literal edit, a regex-literal edit (where the file has one) and an appended declaration.

Regeneration (gen:migration-registry):

  • check:migration-registry exits 1 before and 0 after.
  • The registry diff is 128 lines out and 128 in. As (old, new) pairs they equal the entry diff's pairs, re-indented by four spaces.
  • 0 changed lines fall outside the generated regions.
  • 5 entry pairs are deliberately not carried: the README line, and the semantic "Anchors" header lines, which sit above a blank line and so are not in the carried comment run.
  • check:spec-changes and check:upgrade-guide exit 0 with no regeneration.

Build and tests (under os-verify-lock):

  • Build: turbo run build over ./packages/* and ./packages/*/*, 71 of 71, at 845e90fea4 and again at 1ee5841c09.
  • check:generated: all 15 artifacts up to date, at both heads.
  • spec local project: 576 files, 16,991 passed and 1 todo, at both heads.
  • spec repo project: 41 of its 45 files, 666 passed, at both heads.
  • spec typecheck: exit 0; 53 files / 251 errors / 138 pinned signatures held.

Gates: dispatch-gates --commands derives 82 gates, and the derivation is identical before and after the second merge. At 1ee5841c09 all 82 exit 0. --ran reconciles: 82 derived, 82 run, 0 NOT-MEASURED, a derived zero.

Lint (a proven narrowing):

  • eslint --no-inline-config --format json over the 86 touched .ts files: 86 files, 0 errors, 0 warnings.
  • isPathIgnored is false for all 86.
  • eslint.config.mjs:327-328 states that type-aware linting is never enabled, so a comment edit cannot move an untouched file's verdict.

Changeset: patch.

Merges: origin/main was merged twice through scripts/pm/os-regen-merge.sh. Neither merge left a regeneration to commit.

Acceptance notes


Generated by Claude Code

…s to the commits that decided them

Every dead tracker number in the hand-written migration entries (131 sites
over 21 numbers, all comments; one in entries/README.md) now cites the
commit that decided it, in ruling C+D form C, with the decision in words
where the number alone carried it. The anchors are the ones earlier stages
chose for the same numbers. Lit citations on the same lines stay.

Comment text only: no entry id, literal, order or code token moves.

Claude-Session: https://claude.ai/code/session_014EJ1ED8X4MMrT18BhVx4tx
Co-authored-by: Claude <noreply@anthropic.com>
…ntries

gen:migration-registry output only. The 128 changed lines are the entry
comment lines the generator carries, re-indented; no line outside the
generated regions moves. spec-changes.json and the upgrade guide are
unchanged, because entry comments are never projected into them.

Claude-Session: https://claude.ai/code/session_014EJ1ED8X4MMrT18BhVx4tx
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added size/l documentation Improvements or additions to documentation tooling labels Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 2 documentable anchor(s). ⚠️ 86 changed file(s) yielded no anchor (packages/spec/src/migrations/entries/README.md, packages/spec/src/migrations/entries/retired-defs/17.api__CreateViewRequest.ts, packages/spec/src/migrations/entries/retired-defs/18.api__CrudEndpointPattern.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

1 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/kernel/cluster.mdx (via RETIRED_DEFS_BY_MAJOR (symbol, a top-level const object))
What this run could not see
  • 86 changed file(s) yielded no anchor (packages/spec/src/migrations/entries/README.md, packages/spec/src/migrations/entries/retired-defs/17.api__CreateViewRequest.ts, packages/spec/src/migrations/entries/retired-defs/18.api__CrudEndpointPattern.ts, …) — pages documenting those are invisible to this run
  • 1 name(s) were too generic to anchor anything (single lowercase words)
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 137 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 97005aed04a069abc2d2fa82fd6c1594aebd7cd1 → packageMentionDocs.

Which tree this was computed on

This run read content/docs from 3d26556ab74c39abd96cd3056f0605693de27cd3 — the merge of head 1ee5841c092cdc7d2c446ab1e7cf933b940e3e25 into base 97005aed04a069abc2d2fa82fd6c1594aebd7cd1, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 3d26556ab74c39abd96cd3056f0605693de27cd3 && git checkout 3d26556ab74c39abd96cd3056f0605693de27cd3
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 97005aed04a069abc2d2fa82fd6c1594aebd7cd1 1ee5841c092cdc7d2c446ab1e7cf933b940e3e25 && git checkout -B drift-repro 97005aed04a069abc2d2fa82fd6c1594aebd7cd1 && git merge --no-ff 1ee5841c092cdc7d2c446ab1e7cf933b940e3e25

node scripts/docs-audit/affected-docs.mjs --json 97005aed04a069abc2d2fa82fd6c1594aebd7cd1

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 97005aed04a069abc2d2fa82fd6c1594aebd7cd1 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 1ee5841c092cdc7d2c446ab1e7cf933b940e3e25
Local-runs: probe — one scratch script over the repo's git objects, tokenising the merge-base and head blobs of the 86 changed .ts files with a TypeScript scanner (comments and whitespace dropped) to settle comment-only; nothing built, tested or re-run.

Read: card #20234, body and all 41 comments (the C+D path decision 5856637615, the pointer 5858331362, stage 8's landing 5896689039, stage 9's ACCEPT 5899135835 and landing 5899597998, the stage-10 claim 5901544565, the dev report 5902687602); PR #20750, its body, its one comment, its 88-file list and the net diff against main at the merge base 01e78dceef; the 21 anchor commits by git show and git log; the check-runs on the head, read once.

① Derived judgments

The claim says no accept-set or public-surface move. Each judgment below is from the diff and the git objects, not the dev's prose.

② Semver level

  • patch is right, and its stated reason holds. The diff is comment text, but the comments ship: at this head packages/spec/tsup.config.ts lists src/migrations/index.ts as a bundle entry and package.json exports ./migrations to dist/migrations/index.mjs and index.js (the shared checkout's HEAD, two days older, has neither, which is why the dev's dist measurement is not reproducible there). That the bundler keeps // comments is verified on the published @objectstack/spec@17.5.0 tarball: its dist/index.mjs carries 9,901 comment lines, the old "PR feat(spec): refuse ${…} placeholder syntax in memory persistence.path / persistence.key at publish (#8495) #8666 precedent" phrase 23 times, and the RETIRED_KEYS_BY_MAJOR table with its entry comments. So the compiled @objectstack/spec/migrations entry carries these comments and the changeset's rationale sentence is true. No export, schema, prescription or projected text moves, so nothing above patch applies. Check Changeset is green.
  • Clause-②: no is right, in the PR body and as a standalone line in the changeset: no accept or reject moves, by the comment-only proof.

③ Boundary flags

Check-runs on the head, read once in the first CI wave (the newest concluded run at the read was Dogfood Regression Gate (2/3)), not re-read and not polled. 32 runs: 17 success, 3 skipped, 12 in progress, 0 failed. Green: Check Changeset, Check PR Size, Governed Surface Queue Guard, Spec property liveness, Type Check · source gates, Type Check · consumer gates, Type Check · debt ledger, the four claim, closing-keyword and single-writer guards, Check Documentation Links, Flag docs affected by code changes, Auto Label, filter, Dogfood Verify CLI, Dogfood Regression Gate (2/3). Roster skips: Build Docs, Console Pin Gate, Packed-tarball smoke (opt-in). NOT CONCLUDED at the read, so not presumed green: Lint & Repo Gates (the run carrying check:issue-citations, check:migration-registry, check:spec-changes, check:upgrade-guide, check:doc-authoring and check:generated, the gates closest to this diff), Type Check · workspace, Build Core, Test Core (all six shards), Dogfood Regression Gate (1/3 and 3/3), Temporal Conformance (live PG + MySQL). The derived families the concluded green runs answer: changeset shape and deadline, PR size, governed surface, liveness, the three type-check legs, card and branch parity. The rest is the seat's landing rule; nothing red was seen.

Implemented-by: claude/issue-20234-migrations-citations
Reviewed-by: session_014EJ1ED8X4MMrT18BhVx4tx

VERDICT: PASS


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/l tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants