feat(i18n): update missing Chinese Simple(zh-CN) translations#2367
feat(i18n): update missing Chinese Simple(zh-CN) translations#2367fnoopv wants to merge 1 commit intonpmx-dev:mainfrom
Conversation
|
Hello! Thank you for opening your first PR to npmx, @fnoopv! 🚀 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request expands the Chinese localisation file (zh-CN.json) with 192 new lines of translation strings across multiple UI sections. The changes introduce localised text for brand navigation and assets, enhanced blog and settings sections, improved package and profile displays with skills labels and version information, extended code viewer controls, new filtering and comparison UI components, and additional comparison panel features including diff controls and validation messaging. A complete translation status page section and vacations section with metadata are also added. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| "p1_count": "0 条消息 | 1 条消息 | {count} 条消息", | ||
| "p2": "开始之前，请先阅读我们的 {guide}，了解翻译流程以及你可以如何参与。", | ||
| "guide": "本地化（i18n）指南", | ||
| "by_locale": "按语言区域查看翻译进度", | ||
| "by_file": "按文件查看翻译进度", | ||
| "complete_text": "该翻译已完成，做得太棒了！", | ||
| "missing_text": "缺失", | ||
| "missing_keys": "没有缺失的翻译 | 缺失翻译 | 缺失翻译", |
There was a problem hiding this comment.
Fix the counted translation_status plural strings.
The last p1_count branch should not start with a space, otherwise the surrounding sentence renders with a double space. Also, missing_keys currently drops the number for non-zero cases, so the status no longer tells the reader how many strings are still missing.
[suggested patch]
Suggested patch
- "p1_count": "0 条消息 | 1 条消息 | {count} 条消息",
+ "p1_count": "0 条消息 | 1 条消息 |{count} 条消息",
@@
- "missing_keys": "没有缺失的翻译 | 缺失翻译 | 缺失翻译",
+ "missing_keys": "没有缺失的翻译 | 1 项缺少翻译 | {count} 项缺少翻译",Based on learnings: In locale JSON files under i18n/locales/ (including en.json), for the translation_status.p1_count key’s third plural form, the formatting intentionally omits the space before {count}.
There was a problem hiding this comment.
Could you take a look at this suggestion @fnoopv 🙏
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
| }, | ||
| "chart_view_toggle": "切换视图", | ||
| "chart_view_combined": "合并视图", | ||
| "chart_view_split": "分离视图", |
There was a problem hiding this comment.
I think using "拆分试图" here would be more appropriate.
3 participants
🔗 Linked issue
No GitHub issue, general call for translation support.
🧭 Context
📚 Description
Add missing translation entries.