Skip to content

tools: retry Gatekeeper check and stapling after notarization #66855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Oct 20, 2026
+21 −2
Merged

tools: retry Gatekeeper check and stapling after notarization #66855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions tools/osx-notarize.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,31 @@ else
exit 1
fi

if ! xcrun spctl --assess --type install --context context:primary-signature --ignore-cache --verbose=2 "node-$pkgid.pkg"; then
# The notarization ticket can take a while to become available from Apple's
# servers after notarytool reports "Accepted", so retry with backoff.
retry() {
delay=15
attempt=1
while ! "$@"; do
if [ "$attempt" -ge 6 ]; then
return 1
fi
echo "Attempt $attempt failed, retrying in ${delay}s..."
sleep "$delay"
attempt=$((attempt + 1))
delay=$((delay * 2))
done
}

if ! retry xcrun spctl --assess --type install --context context:primary-signature --ignore-cache --verbose=2 "node-$pkgid.pkg"; then
echo "error: Signature will not be accepted by Gatekeeper!" 1>&2
exit 1
else
echo "Verification was successful."
fi

xcrun stapler staple "node-$pkgid.pkg"
if ! retry xcrun stapler staple "node-$pkgid.pkg"; then
echo "error: Stapling node-$pkgid.pkg failed." 1>&2
exit 1
fi
echo "Stapler was successful."
Loading