Repository navigation
tools: retry Gatekeeper check and stapling after notarization - #66855
Merged
Merged
Conversation
Apple's ticket service can lag behind notarytool reporting "Accepted", which makes the spctl assessment fail with "source=Unnotarized Developer ID" even though the package was notarized. Retry spctl and stapler with exponential backoff (up to ~7.5 minutes) before failing, and fail the script if stapling does not succeed instead of ignoring its exit status. Refs: nodejs/build#4527 Signed-off-by: Ryan Aslett <raslett@linuxfoundation.org>
nodejs-github-bot
added
macos
lpinca
approved these changes
Oct 19, 2026
richardlau
approved these changes
Oct 20, 2026
aduh95
added
fast-track
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Collaborator
|
Landed in 1b5fc14 |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When notarizing apple releases, Apple's ticket service can potentially have slow response times, and our script is immediately checking and failing if Apple's service hasnt caught up, which makes the spctl assessment fail with "source=Unnotarized Developer ID" even though the package was notarized.
This adds a retry loop to the spctl and stapler commands with exponential backoff (up to ~7.5 minutes) before failing, and fails the script if stapling does not succeed instead of ignoring its exit status.
Refs: nodejs/build#4527