plugins/bufferline: migrate to mkNeovimPlugin

[khaneliman]

Resolves #1890

Also added support:

• separator_style for the custom separator declaration using an array of 2 strings.
• indicator.style allow for none

Changed:

• diagnostics no longer accepts true. Plugin only accepts false, nvim_lsp, or coc.
• diagnosticsUpdateInInsert uses vim.diagnostic.config instead of passing into options table.
• Updated some descriptions with notes from upstream docs on usage.

[khaneliman]

@GaetanLepage I see you touched this a bit before, so would also like your eyes.

[GaetanLepage]

I will have a look later today, thanks !

[MattSturgeon]

I think this PR is mostly done, last few suggestions and questions!

[MattSturgeon]

I'm happy, thanks for your work on this!

Two more nits below, but they're not too important.

[mergify]

queue

❌ Command disallowed due to command restrictions in the Mergify configuration.

• sender-permission>=write

[GaetanLepage]

LGTM, thanks !

[GaetanLepage]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at cb398ce

[ajaxbits]

Seeing this bug:

┏━ 1 Errors:
 ⋮
┃            39|       paths = [
┃              |       ^
┃            40|         config.finalPackage
┃
┃        (stack trace truncated; use '--show-trace' to show the full trace)
┃
┃        error: attribute 'nixvim' missing
┃        at /nix/store/vdwmiyrhb8as39shk5hgqlb5p1g7ra21-source/plugins/bufferlines/bufferline.nix:11:1:
┃            10| in
┃            11| lib.nixvim.neovim-plugin.mkNeovimPlugin config {
┃              | ^
┃            12|   name = "bufferline";
┣━━━
┗━ ∑ ⚠ Exited with 1 errors reported by nix at 13:28:01 after 1s

[khaneliman]

Seeing this bug:

┏━ 1 Errors:
 ⋮
┃            39|       paths = [
┃              |       ^
┃            40|         config.finalPackage
┃
┃        (stack trace truncated; use '--show-trace' to show the full trace)
┃
┃        error: attribute 'nixvim' missing
┃        at /nix/store/vdwmiyrhb8as39shk5hgqlb5p1g7ra21-source/plugins/bufferlines/bufferline.nix:11:1:
┃            10| in
┃            11| lib.nixvim.neovim-plugin.mkNeovimPlugin config {
┃              | ^
┃            12|   name = "bufferline";
┣━━━
┗━ ∑ ⚠ Exited with 1 errors reported by nix at 13:28:01 after 1s

Confusing to say the least... it built and tested fine and I'm using the config myself..

[ajaxbits]

Here's the code I'm working with: https://github.com/ajaxbits/nvim/tree/ef8eb6410366e7aed4189cb407585e75b7756434

Gonna keep debugging, but feel free to give it a look if you want.

[MattSturgeon]

@ajaxbits you override the lib we use here: https://github.com/ajaxbits/nvim/blob/ef8eb6410366e7aed4189cb407585e75b7756434/flake.nix#L34

Which isn't supported because it means our "extended" lib isn't used.

Can you open an issue explaining why you want to do that and I'll try and come up with something 🤔

[ajaxbits]

Ah thank you for the explainer. I don't know why that was set. Weirdly, it was working for me all this time until recently. Who knows what that's all about. Removing that SpecialArg fixed my issue. Thank you for your time, and sorry for the false report!

[MattSturgeon]

I don't know why that was set. Weirdly, it was working for me all this time until recently. Who knows what that's all about.

Using an extended lib in our modules is a pretty new change: #1963